Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RAD-143, RAD-144: Add FPS and TVAC schemas #364

Merged
merged 18 commits into from
Feb 28, 2024
Merged

RAD-143, RAD-144: Add FPS and TVAC schemas #364

Show file tree
Hide file tree
Changes from 15 commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
fd758f1
Add ground exposure schema
WilliamJamieson Jan 29, 2024
7e298d1
Update exposure schema to reference ground exposure
WilliamJamieson Jan 29, 2024
562c10e
Add ground guidestar
WilliamJamieson Jan 29, 2024
35ff5eb
Update guidestar to ref ground data
WilliamJamieson Jan 29, 2024
f1de2b8
Add ground test schema
WilliamJamieson Jan 30, 2024
657ecd8
Added FPS schemas
WilliamJamieson Jan 29, 2024
86064e1
Add tvac schema
WilliamJamieson Jan 29, 2024
cadd467
Re-organize some of the schemas
WilliamJamieson Feb 9, 2024
2d65fbe
Update unit for LED
WilliamJamieson Feb 9, 2024
3a822ff
Update changelog
WilliamJamieson Feb 6, 2024
194a8fd
Add archive destination information
WilliamJamieson Feb 9, 2024
00182c9
Add exact datatype where needed
WilliamJamieson Feb 9, 2024
9531910
Update with Jason's table names
WilliamJamieson Feb 9, 2024
efd7631
Address review comments
WilliamJamieson Feb 22, 2024
4668d68
More suggested changes
WilliamJamieson Feb 23, 2024
ccb8ee3
Rebased.
PaulHuwe Feb 27, 2024
0c23a56
Updated for rebase changes. Renamed ground_exposure and _guidestar to…
PaulHuwe Feb 27, 2024
37e5c7a
Reinstating accidentally deleted tags.
PaulHuwe Feb 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGES.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@

- Add documentation on how to create a new schema. [#375]

- Add ``FPS`` and ``TVAC`` schemas. [#364]

0.19.0 (2024-02-09)
-------------------

Expand Down
31 changes: 31 additions & 0 deletions src/rad/resources/manifests/datamodels-1.0.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,37 @@ tags:
title: Mosaic WCS parameters
description: |-
Mosaic WCS parameters
# Ground Modules
- tag_uri: asdf://stsci.edu/datamodels/roman/tags/ground_exposure-1.0.0
schema_uri: asdf://stsci.edu/datamodels/roman/schemas/ground_exposure-1.0.0
title: Exposure information
description: |-
Ground test exposure information
- tag_uri: asdf://stsci.edu/datamodels/roman/tags/ground_guidestar-1.0.0
schema_uri: asdf://stsci.edu/datamodels/roman/schemas/ground_guidestar-1.0.0
title: Guidestar information
description: |-
Guidestar information
- tag_uri: asdf://stsci.edu/datamodels/roman/tags/groundtest-1.0.0
schema_uri: asdf://stsci.edu/datamodels/roman/schemas/groundtest-1.0.0
title: Ground Test Information
description: |-
Ground test description.
- tag_uri: asdf://stsci.edu/datamodels/roman/tags/tvac_groundtest-1.0.0
schema_uri: asdf://stsci.edu/datamodels/roman/schemas/tvac_groundtest-1.0.0
title: TVAC Ground Test Information
description: |-
TVAC ground test description.
- tag_uri: asdf://stsci.edu/datamodels/roman/tags/fps-1.0.0
schema_uri: asdf://stsci.edu/datamodels/roman/schemas/fps-1.0.0
title: FPS schema
description: |-
FPS test data
- tag_uri: asdf://stsci.edu/datamodels/roman/tags/tvac-1.0.0
schema_uri: asdf://stsci.edu/datamodels/roman/schemas/tvac-1.0.0
title: TVAC schema
description: |-
TVAC test data
# Reference Modules
- tag_uri: asdf://stsci.edu/datamodels/roman/tags/reference_files/dark-1.0.0
schema_uri: asdf://stsci.edu/datamodels/roman/schemas/reference_files/dark-1.0.0
Expand Down
30 changes: 15 additions & 15 deletions src/rad/resources/schemas/cal_step-1.0.0.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,105 +12,105 @@ properties:
enum: ['N/A', 'COMPLETE', 'SKIPPED', 'INCOMPLETE']
archive_catalog:
datatype: nvarchar(15)
destination: [ScienceRefData.s_assign_wcs, GuideWindow.s_assign_wcs]
destination: [ScienceRefData.s_assign_wcs, GuideWindow.s_assign_wcs, WFICommon.s_assign_wcs]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kdupriestsci Not related to this PR, only for my understanding - do we need GuideWindow table updates for the cal_step entries if we are not processing Guide windows?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not the correct person to ask. Maybe @tddesjardins can weigh in?

flat_field:
title: Flat Field Step
type: string
enum: ['N/A', 'COMPLETE', 'SKIPPED', 'INCOMPLETE']
archive_catalog:
datatype: nvarchar(15)
destination: [ScienceRefData.s_flat_field, GuideWindow.s_flat_field]
destination: [ScienceRefData.s_flat_field, GuideWindow.s_flat_field, WFICommon.s_flat_field]
dark:
title: Dark Subtraction
type: string
enum: ['N/A', 'COMPLETE', 'SKIPPED', 'INCOMPLETE']
archive_catalog:
datatype: nvarchar(15)
destination: [ScienceRefData.s_dark, GuideWindow.s_dark]
destination: [ScienceRefData.s_dark, GuideWindow.s_dark, WFICommon.s_dark]
dq_init:
title: Data Quality Mask Step
type: string
enum: ['N/A', 'COMPLETE', 'SKIPPED', 'INCOMPLETE']
archive_catalog:
datatype: nvarchar(15)
destination: [ScienceRefData.s_dq_init, GuideWindow.s_dq_init]
destination: [ScienceRefData.s_dq_init, GuideWindow.s_dq_init, WFICommon.s_dq_init]
jump:
title: Jump Detection Step
type: string
enum: ['N/A', 'COMPLETE', 'SKIPPED', 'INCOMPLETE']
archive_catalog:
datatype: nvarchar(15)
destination: [ScienceRefData.s_jump, GuideWindow.s_jump]
destination: [ScienceRefData.s_jump, GuideWindow.s_jump, WFICommon.s_jump]
linearity:
title: Linearity Correction
type: string
enum: ['N/A', 'COMPLETE', 'SKIPPED', 'INCOMPLETE']
archive_catalog:
datatype: nvarchar(15)
destination: [ScienceRefData.s_linearity, GuideWindow.s_linearity]
destination: [ScienceRefData.s_linearity, GuideWindow.s_linearity, WFICommon.s_linearity]
photom:
title: Photometry Step
type: string
enum: ['N/A', 'COMPLETE', 'SKIPPED', 'INCOMPLETE']
archive_catalog:
datatype: nvarchar(15)
destination: [ScienceRefData.s_photom, GuideWindow.s_photom]
destination: [ScienceRefData.s_photom, GuideWindow.s_photom, WFICommon.s_photom]
source_detection:
title: Source Detection Step
type: string
enum: ['N/A', 'COMPLETE', 'SKIPPED', 'INCOMPLETE']
archive_catalog:
datatype: nvarchar(15)
destination: [ScienceRefData.s_source_detection, GuideWindow.s_source_detection]
destination: [ScienceRefData.s_source_detection, GuideWindow.s_source_detection, WFICommon.s_source_detection]
ramp_fit:
title: Ramp Fitting
type: string
enum: ['N/A', 'COMPLETE', 'SKIPPED', 'INCOMPLETE']
archive_catalog:
datatype: nvarchar(15)
destination: [ScienceRefData.s_ramp_fit, GuideWindow.s_ramp_fit]
destination: [ScienceRefData.s_ramp_fit, GuideWindow.s_ramp_fit, WFICommon.s_ramp_fit]
refpix:
title: Reference Pixel Correction
type: string
enum: ['N/A', 'COMPLETE', 'SKIPPED', 'INCOMPLETE']
archive_catalog:
datatype: nvarchar(15)
destination: [ScienceRefData.s_refpix, GuideWindow.s_refpix]
destination: [ScienceRefData.s_refpix, GuideWindow.s_refpix, WFICommon.s_refpix]
saturation:
title: Saturation Checking
type: string
enum: ['N/A', 'COMPLETE', 'SKIPPED', 'INCOMPLETE']
archive_catalog:
datatype: nvarchar(15)
destination: [ScienceRefData.s_saturation, GuideWindow.s_saturation]
destination: [ScienceRefData.s_saturation, GuideWindow.s_saturation, WFICommon.s_saturation]
outlier_detection:
title: outlier_detection
type: string
enum: ['N/A', 'COMPLETE', 'SKIPPED', 'INCOMPLETE']
archive_catalog:
datatype: nvarchar(15)
destination: [ScienceRefData.s_outlier_detection, GuideWindow.s_outlier_detection]
destination: [ScienceRefData.s_outlier_detection, GuideWindow.s_outlier_detection, WFICommon.s_outlier_detection]
tweakreg:
title: Tweakreg step
type: string
enum: ['N/A', 'COMPLETE', 'SKIPPED', 'INCOMPLETE']
archive_catalog:
datatype: nvarchar(15)
destination: [ScienceRefData.s_tweakreg, GuideWindow.s_tweakreg]
destination: [ScienceRefData.s_tweakreg, GuideWindow.s_tweakreg, WFICommon.s_tweakreg]
skymatch:
title: Sky Match step
type: string
enum: ['N/A', 'COMPLETE', 'SKIPPED', 'INCOMPLETE']
archive_catalog:
datatype: nvarchar(15)
destination: [ScienceRefData.s_skymatch, GuideWindow.s_skymatch]
destination: [ScienceRefData.s_skymatch, GuideWindow.s_skymatch, WFICommon.s_skymatch]
resample:
title: Resample Step
type: string
enum: ['N/A', 'COMPLETE', 'SKIPPED', 'INCOMPLETE']
archive_catalog:
datatype: nvarchar(15)
destination: [ScienceRefData.s_resample, GuideWindow.s_resample]
destination: [ScienceRefData.s_resample, GuideWindow.s_resample, WFICommon.s_resample]
propertyOrder: [assign_wcs, flat_field, dark, dq_init, jump, linearity, photom, source_detection, outlier_detection, ramp_fit, refpix, saturation, skymatch, tweakreg, resample]
flowStyle: block
required: [assign_wcs, flat_field, dark, dq_init, jump, linearity, outlier_detection, photom, source_detection, ramp_fit, refpix, resample, saturation, skymatch, tweakreg]
Expand Down
Loading