Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move common resample code to stcal #8695

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
+922 −157

remove bad assert

f6677e8
Select commit
Loading
Failed to load commit list.
Draft

Move common resample code to stcal #8695

remove bad assert
f6677e8
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Oct 26, 2024 in 0s

55.47% (-6.46%) compared to 1561909

View this Pull Request on Codecov

55.47% (-6.46%) compared to 1561909

Details

Codecov Report

Attention: Patch coverage is 4.38356% with 349 lines in your changes missing coverage. Please review.

Project coverage is 55.47%. Comparing base (1561909) to head (f6677e8).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
jwst/resample/resample.py 3.37% 143 Missing ⚠️
jwst/resample/resample_step.py 4.58% 104 Missing ⚠️
jwst/resample/gwcs_drizzle.py 3.22% 90 Missing ⚠️
jwst/resample/resample_utils.py 22.22% 7 Missing ⚠️
jwst/resample/resample_spec_step.py 16.66% 5 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8695      +/-   ##
==========================================
- Coverage   61.92%   55.47%   -6.46%     
==========================================
  Files         376      377       +1     
  Lines       38685    38962     +277     
==========================================
- Hits        23957    21615    -2342     
- Misses      14728    17347    +2619

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov