Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport PR #3400 on branch v4.1.x (BUG: source_id is lowercase in Gaia output (sometimes)) #3404

Conversation

meeseeksmachine
Copy link

Backport PR #3400: BUG: source_id is lowercase in Gaia output (sometimes)

@lumberbot-app lumberbot-app bot added this to the 4.1.1 milestone Jan 22, 2025
@lumberbot-app lumberbot-app bot added bug Something isn't working imviz trivial Only needs one approval instead of two labels Jan 22, 2025
@lumberbot-app lumberbot-app bot added the plugin Label for plugins common to multiple configurations label Jan 22, 2025
@lumberbot-app lumberbot-app bot added the backport-v4.1.x on-merge: backport to v4.1.x label Jan 22, 2025
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.08%. Comparing base (495e49a) to head (0cc1ce0).
Report is 6 commits behind head on v4.1.x.

Files with missing lines Patch % Lines
jdaviz/configs/imviz/plugins/catalogs/catalogs.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           v4.1.x    #3404   +/-   ##
=======================================
  Coverage   88.08%   88.08%           
=======================================
  Files         127      127           
  Lines       19594    19595    +1     
=======================================
+ Hits        17260    17261    +1     
  Misses       2334     2334           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pllim pllim merged commit ae3063a into spacetelescope:v4.1.x Jan 22, 2025
42 of 44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v4.1.x on-merge: backport to v4.1.x bug Something isn't working imviz plugin Label for plugins common to multiple configurations trivial Only needs one approval instead of two
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants