-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generalize specviz/2d load_data #3399
Draft
kecnry
wants to merge
11
commits into
spacetelescope:main
Choose a base branch
from
kecnry:deconf-load-data
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+122
−97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* 2d->1d spectra have been handled by the spectral extraction plugin for a while and logic no longer goes through here
github-actions
bot
added
specviz
mosviz
plugin
Label for plugins common to multiple configurations
specviz2d
labels
Jan 21, 2025
kecnry
force-pushed
the
deconf-load-data
branch
from
January 21, 2025 17:57
b60c911
to
e9ed798
Compare
kecnry
force-pushed
the
deconf-load-data
branch
from
January 22, 2025 17:34
c545829
to
03449c5
Compare
kecnry
force-pushed
the
deconf-load-data
branch
from
January 22, 2025 18:14
176764c
to
bcef771
Compare
kecnry
commented
Jan 23, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as far as I can tell, this parser hasn't been used since we began using the spectral extraction plugin in specviz2d
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request generalizes
load_data
in specviz to parse 1d and 2d spectra as well as specreduce trace objects. This does not yet allow visualizing or analyzing 2d spectral data in specviz, but lays the groundwork for adding those viewers/plugins. Because of that, this is temporarily behind a developer flag:Note that this is not the intended eventual design of the general parsers, but rather a temporary (slightly hacky) solution to get the existing parsers in specviz2d to work in specviz so that we can continue with the rest of the implementation of context-aware viewers and plugins which then will hopefully help inform the refactored parsers in the future.
TODO:
Change log entry
CHANGES.rst
? If you want to avoid merge conflicts,list the proposed change log here for review and add to
CHANGES.rst
before merge. If no, maintainershould add a
no-changelog-entry-needed
label.Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
trivial
label.