Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport PR #2656 on branch v3.8.x (TST: Handle second warning in test_all_nan_uncert_subset) #2657

Merged
merged 1 commit into from
Jan 8, 2024
Merged

Backport PR #2656 on branch v3.8.x (TST: Handle second warning in test_all_nan_uncert_subset) #2657

merged 1 commit into from
Jan 8, 2024

Conversation

meeseeksmachine
Copy link

Backport PR #2656: TST: Handle second warning in test_all_nan_uncert_subset

@lumberbot-app lumberbot-app bot added this to the 3.8.2 milestone Jan 8, 2024
@lumberbot-app lumberbot-app bot added bug Something isn't working testing trivial Only needs one approval instead of two no-changelog-entry-needed changelog bot directive plugin Label for plugins common to multiple configurations 💤backport-v3.8.x on-merge: backport to v3.8.x labels Jan 8, 2024
@codecov Codecov
Copy link

codecov bot commented Jan 8, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (1cdd265) 91.47% compared to head (1dcde61) 91.46%.

Files Patch % Lines
...default/plugins/model_fitting/tests/test_plugin.py 85.71% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           v3.8.x    #2657      +/-   ##
==========================================
- Coverage   91.47%   91.46%   -0.01%     
==========================================
  Files         160      160              
  Lines       19581    19587       +6     
==========================================
+ Hits        17911    17916       +5     
- Misses       1670     1671       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pllim pllim merged commit cc92f4a into spacetelescope:v3.8.x Jan 8, 2024
28 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pllim pllim pllim approved these changes

@rosteen rosteen Awaiting requested review from rosteen rosteen is a code owner

@javerbukh javerbukh Awaiting requested review from javerbukh javerbukh is a code owner

@kecnry kecnry Awaiting requested review from kecnry kecnry is a code owner

@bmorris3 bmorris3 Awaiting requested review from bmorris3 bmorris3 is a code owner

@haticekaratay haticekaratay Awaiting requested review from haticekaratay haticekaratay is a code owner

@cshanahan1 cshanahan1 Awaiting requested review from cshanahan1 cshanahan1 is a code owner

Assignees
No one assigned
Labels
bug Something isn't working no-changelog-entry-needed changelog bot directive plugin Label for plugins common to multiple configurations testing trivial Only needs one approval instead of two 💤backport-v3.8.x on-merge: backport to v3.8.x
Projects
None yet
Milestone
3.8.2
Development

Successfully merging this pull request may close these issues.
2 participants
@meeseeksmachine @pllim