Test get_data when changing a subsets label #2609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javerbukh
requested review from
rosteen,
pllim,
kecnry,
bmorris3,
haticekaratay,
cshanahan1 and
gibsongreen
as code owners
kecnry
approved these changes
Dec 12, 2023
|
What if you change the subset name to be the same as data name? Will the app get confused? |
|
@pllim Added that case to the test and it still retrieves the data with the subset applied as expected. |
pllim
reviewed
Dec 15, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2609 +/- ##
==========================================
- Coverage 91.54% 91.53% -0.02%
==========================================
Files 161 161
Lines 19757 19944 +187
==========================================
+ Hits 18086 18255 +169
- Misses 1671 1689 +18 ☔ View full report in Codecov by Sentry. |
pllim
reviewed
Dec 15, 2023
jdaviz/tests/test_subsets.py
Outdated
Comment on lines
978
to
979
| assert (set(get_data_1_mask[0]) - set(get_data_2_mask[0]) | ||
| == set(get_data_2_mask[0]) - set(get_data_1_mask[0])) |
There was a problem hiding this comment.
I don't understand this check, is simple array compare insufficient here?
There was a problem hiding this comment.
Yes, can you tell its Friday? 💀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds a test that makes sure renaming a subset does not change the result of a
get_datacall.Change log entry
CHANGES.rst? If you want to avoid merge conflicts,list the proposed change log here for review and add to
CHANGES.rstbefore merge. If no, maintainershould add a
no-changelog-entry-neededlabel.Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
triviallabel.