add @gibsongreen to codeowners/mailmap/citation #2600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pllim
reviewed
Dec 7, 2023
| @@ -4,4 +4,4 @@ | |||
| # the repo. Unless a later match takes precedence, | |||
| # they will be requested for | |||
| # review when someone opens a pull request. | |||
| * @rosteen @javerbukh @pllim @kecnry @bmorris3 @haticekaratay @cshanahan1 | |||
| * @rosteen @javerbukh @pllim @kecnry @bmorris3 @haticekaratay @cshanahan1 @gibsongreen | |||
There was a problem hiding this comment.
I invited @gibsongreen to the Indigo Team. Once he accepted, this error would go away.
There was a problem hiding this comment.
Should be valid now, please confirm.
There was a problem hiding this comment.
I can see myself on the team page as of yesterday @pllim
kecnry
requested review from
rosteen,
javerbukh,
bmorris3,
haticekaratay and
cshanahan1
as code owners
kecnry
commented
Dec 11, 2023
| @@ -27,6 +27,8 @@ authors: | |||
| - family-names: "Geda" | |||
| given-names: "Robel" | |||
| orcid: "https://orcid.org/0000-0003-1509-9966" | |||
| - family-names: "Green" | |||
| given-names: "Gilbert" | |||
There was a problem hiding this comment.
@gibsongreen - did you want to list an orcid? Otherwise if you're happy with everything, feel free to approve and we'll get this in!
There was a problem hiding this comment.
@kecnry, sorry I meant to send the id sooner, thank you!
gibsongreen
approved these changes
Dec 11, 2023
| @@ -27,6 +27,8 @@ authors: | |||
| - family-names: "Geda" | |||
| given-names: "Robel" | |||
| orcid: "https://orcid.org/0000-0003-1509-9966" | |||
| - family-names: "Green" | |||
| given-names: "Gilbert" | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds @gibsongreen to the codeowners, mailmap, and citation file.
TODO: