Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport PR #2576 on branch v3.8.x (Specviz Parser handling HDULists) #2599

Conversation

meeseeksmachine
Copy link

Backport PR #2576: Specviz Parser handling HDULists

@lumberbot-app lumberbot-app bot added this to the 3.8.1 milestone Dec 7, 2023
@lumberbot-app lumberbot-app bot added bug Something isn't working specviz 💤backport-v3.8.x on-merge: backport to v3.8.x labels Dec 7, 2023
Copy link

codecov bot commented Dec 7, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (e999bfa) 91.48% compared to head (46124f6) 91.48%.

Files Patch % Lines
jdaviz/configs/specviz/plugins/parsers.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           v3.8.x    #2599   +/-   ##
=======================================
  Coverage   91.48%   91.48%           
=======================================
  Files         160      160           
  Lines       19523    19540   +17     
=======================================
+ Hits        17860    17876   +16     
- Misses       1663     1664    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pllim pllim merged commit 0d9d305 into spacetelescope:v3.8.x Dec 7, 2023
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working specviz 💤backport-v3.8.x on-merge: backport to v3.8.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants