Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update min python in pyproject #2597

Merged
merged 1 commit into from
Dec 7, 2023
Merged

Conversation

kecnry
Copy link
Member

@kecnry kecnry commented Dec 7, 2023

Description

#2152 removed support for python 3.8, but the min version in pyproject.toml was not updated

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

spacetelescope#2152 removed support for python 3.8, but the min version in pyproject.toml was not updated
@kecnry kecnry added trivial Only needs one approval instead of two no-changelog-entry-needed changelog bot directive 💤backport-v3.8.x on-merge: backport to v3.8.x labels Dec 7, 2023
@kecnry kecnry added this to the 3.8.1 milestone Dec 7, 2023
@kecnry kecnry marked this pull request as ready for review December 7, 2023 18:35
Copy link
Contributor

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, he did update setup.cfg so maybe that change was lost when he came back to get rid of setup.cfg . 🤷

Thanks!

@pllim pllim enabled auto-merge December 7, 2023 18:48
Copy link

codecov bot commented Dec 7, 2023

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (bd312bd) 91.51% compared to head (628582e) 91.53%.
Report is 1 commits behind head on main.

Files Patch % Lines
...plugins/spectral_extraction/spectral_extraction.py 86.48% 5 Missing ⚠️
...daviz/configs/default/plugins/collapse/collapse.py 86.48% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2597      +/-   ##
==========================================
+ Coverage   91.51%   91.53%   +0.01%     
==========================================
  Files         161      161              
  Lines       19596    19724     +128     
==========================================
+ Hits        17934    18054     +120     
- Misses       1662     1670       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pllim pllim merged commit f8305b6 into spacetelescope:main Dec 7, 2023
20 of 21 checks passed
Copy link

lumberbot-app bot commented Dec 7, 2023

Something went wrong ... Please have a look at my logs.

It seems that the branch you are trying to backport to does not exist.

@kecnry
Copy link
Member Author

kecnry commented Dec 7, 2023

@meeseeksdev backport to v3.8.x

(seems that since the branch didn't exist when the label was created, we're always going to have to do this for 3.8... or can we recreate the label?)

@pllim
Copy link
Contributor

pllim commented Dec 7, 2023

So weird that the label creation time matters. You can try to recreate the label and see. 🤞

pllim added a commit that referenced this pull request Dec 7, 2023
…7-on-v3.8.x

Backport PR #2597 on branch v3.8.x (update min python in pyproject)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog-entry-needed changelog bot directive trivial Only needs one approval instead of two 💤backport-v3.8.x on-merge: backport to v3.8.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants