-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update min python in pyproject #2597
Conversation
spacetelescope#2152 removed support for python 3.8, but the min version in pyproject.toml was not updated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huh, he did update setup.cfg so maybe that change was lost when he came back to get rid of setup.cfg . 🤷
Thanks!
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2597 +/- ##
==========================================
+ Coverage 91.51% 91.53% +0.01%
==========================================
Files 161 161
Lines 19596 19724 +128
==========================================
+ Hits 17934 18054 +120
- Misses 1662 1670 +8 ☔ View full report in Codecov by Sentry. |
Something went wrong ... Please have a look at my logs. It seems that the branch you are trying to backport to does not exist. |
@meeseeksdev backport to v3.8.x (seems that since the branch didn't exist when the label was created, we're always going to have to do this for 3.8... or can we recreate the label?) |
So weird that the label creation time matters. You can try to recreate the label and see. 🤞 |
…7-on-v3.8.x Backport PR #2597 on branch v3.8.x (update min python in pyproject)
Description
#2152 removed support for python 3.8, but the min version in pyproject.toml was not updated
Change log entry
CHANGES.rst
? If you want to avoid merge conflicts,list the proposed change log here for review and add to
CHANGES.rst
before merge. If no, maintainershould add a
no-changelog-entry-needed
label.Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
trivial
label.