-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TST: Fix ds9_annulus_01.reg test case #2589
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pllim
added
bug
Something isn't working
testing
trivial
Only needs one approval instead of two
no-changelog-entry-needed
changelog bot directive
💤backport-v3.8.x
on-merge: backport to v3.8.x
labels
Dec 5, 2023
pllim
requested review from
rosteen,
javerbukh,
kecnry,
bmorris3,
haticekaratay and
cshanahan1
as code owners
December 5, 2023 23:32
cshanahan1
approved these changes
Dec 5, 2023
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
No user-facing functionality is affected. Just that the test was poorly written. My bad.
pllim
force-pushed
the
fix-ann-reg-test
branch
from
December 6, 2023 02:56
67050d0
to
d6d8a64
Compare
@meeseeksdev backport to v3.8.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/jdaviz
that referenced
this pull request
Dec 6, 2023
pllim
added a commit
that referenced
this pull request
Dec 6, 2023
…9-on-v3.8.x Backport PR #2589 on branch v3.8.x (TST: Fix ds9_annulus_01.reg test case)
pllim
added a commit
to bmorris3/jdaviz
that referenced
this pull request
Dec 9, 2023
TST: Fix ds9_annulus_01.reg test case
11 tasks
bmorris3
pushed a commit
to bmorris3/jdaviz
that referenced
this pull request
Jan 17, 2024
TST: Fix ds9_annulus_01.reg test case
gibsongreen
pushed a commit
to gibsongreen/jdaviz
that referenced
this pull request
Feb 12, 2024
TST: Fix ds9_annulus_01.reg test case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
imviz
no-changelog-entry-needed
changelog bot directive
testing
trivial
Only needs one approval instead of two
💤backport-v3.8.x
on-merge: backport to v3.8.x
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix
ds9_annulus_01.reg
test case. No user-facing functionality is affected. Just that the test was poorly written. My bad.Thanks to @cshanahan1 for catching this!
Change log entry
CHANGES.rst
? If you want to avoid merge conflicts,list the proposed change log here for review and add to
CHANGES.rst
before merge. If no, maintainershould add a
no-changelog-entry-needed
label.Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
trivial
label.