Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: Fix ds9_annulus_01.reg test case #2589

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Dec 5, 2023

Description

Fix ds9_annulus_01.reg test case. No user-facing functionality is affected. Just that the test was poorly written. My bad.

Thanks to @cshanahan1 for catching this!

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)? 🐱

@pllim pllim added bug Something isn't working testing trivial Only needs one approval instead of two no-changelog-entry-needed changelog bot directive 💤backport-v3.8.x on-merge: backport to v3.8.x labels Dec 5, 2023
@pllim pllim added this to the 3.8.1 milestone Dec 5, 2023
@github-actions github-actions bot added the imviz label Dec 5, 2023
@pllim

This comment was marked as outdated.

@pllim

This comment was marked as resolved.

No user-facing functionality is affected.
Just that the test was poorly written. My bad.
@pllim pllim removed the 💤backport-v3.8.x on-merge: backport to v3.8.x label Dec 6, 2023
@pllim pllim modified the milestones: 3.8.1, 3.9 Dec 6, 2023
@pllim pllim enabled auto-merge December 6, 2023 03:05
@pllim pllim merged commit a86e698 into spacetelescope:main Dec 6, 2023
12 of 13 checks passed
@pllim pllim deleted the fix-ann-reg-test branch December 6, 2023 03:26
@pllim pllim added the 💤backport-v3.8.x on-merge: backport to v3.8.x label Dec 6, 2023
@pllim pllim modified the milestones: 3.9, 3.8.1 Dec 6, 2023
@pllim
Copy link
Contributor Author

pllim commented Dec 6, 2023

@meeseeksdev backport to v3.8.x

meeseeksmachine pushed a commit to meeseeksmachine/jdaviz that referenced this pull request Dec 6, 2023
pllim added a commit that referenced this pull request Dec 6, 2023
…9-on-v3.8.x

Backport PR #2589 on branch v3.8.x (TST: Fix ds9_annulus_01.reg test case)
pllim added a commit to bmorris3/jdaviz that referenced this pull request Dec 9, 2023
@pllim pllim mentioned this pull request Dec 9, 2023
11 tasks
bmorris3 pushed a commit to bmorris3/jdaviz that referenced this pull request Jan 17, 2024
gibsongreen pushed a commit to gibsongreen/jdaviz that referenced this pull request Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working imviz no-changelog-entry-needed changelog bot directive testing trivial Only needs one approval instead of two 💤backport-v3.8.x on-merge: backport to v3.8.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants