Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove spline stretch from the registry #2585

Closed

Conversation

haticekaratay
Copy link
Contributor

Description

This pull request is to address ...

Fixes #

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@haticekaratay haticekaratay marked this pull request as ready for review November 30, 2023 16:43
@kecnry kecnry added this to the 3.8.1 milestone Nov 30, 2023
@kecnry kecnry added the 💤backport-v3.8.x on-merge: backport to v3.8.x label Nov 30, 2023
@kecnry
Copy link
Member

kecnry commented Nov 30, 2023

(let's hold off on merging - we're considering supporting the new and old syntax for now instead of max-pinning so we can benefit from other upcoming upstream bugfixes)

@kecnry
Copy link
Member

kecnry commented Nov 30, 2023

After some testing, looks like we don't need to max-pin glue-jupyter after all, and the spline still works on both current and future glue-jupyter (it just won't be interactive until #2545 gets in).

@kecnry kecnry closed this Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💤backport-v3.8.x on-merge: backport to v3.8.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants