Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't set style twice #2583

Merged
merged 1 commit into from
Nov 29, 2023
Merged

Don't set style twice #2583

merged 1 commit into from
Nov 29, 2023

Conversation

rosteen
Copy link
Collaborator

@rosteen rosteen commented Nov 29, 2023

I noticed style was getting set here twice, this removes the second one and some stray white space that snuck in at some point.

@rosteen rosteen added trivial Only needs one approval instead of two no-changelog-entry-needed changelog bot directive labels Nov 29, 2023
@rosteen rosteen added this to the 3.8 milestone Nov 29, 2023
pllim
pllim approved these changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uncontroversial enough. Good catch. Thanks!

@pllim pllim enabled auto-merge November 29, 2023 16:41
@pllim pllim disabled auto-merge November 29, 2023 17:03
@pllim pllim merged commit 66db3f8 into spacetelescope:main Nov 29, 2023
14 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pllim pllim pllim approved these changes

@kecnry kecnry kecnry approved these changes

@javerbukh javerbukh Awaiting requested review from javerbukh javerbukh is a code owner

@bmorris3 bmorris3 Awaiting requested review from bmorris3 bmorris3 is a code owner

@haticekaratay haticekaratay Awaiting requested review from haticekaratay haticekaratay is a code owner

@cshanahan1 cshanahan1 Awaiting requested review from cshanahan1 cshanahan1 is a code owner

Assignees
No one assigned
Labels
no-changelog-entry-needed changelog bot directive trivial Only needs one approval instead of two
Projects
None yet
Milestone
3.8
Development

Successfully merging this pull request may close these issues.
3 participants
@rosteen @kecnry @pllim