Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only include stretch tool in stretch histogram #2556

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

kecnry
Copy link
Member

@kecnry kecnry commented Nov 8, 2023

Description

This pull request removes the stretch bounds tool, introduced in #2513 (milestoned to 3.8, so no need for a bugfix here), from all viewers except the stretch histogram.

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@kecnry kecnry added this to the 3.8 milestone Nov 8, 2023
@kecnry kecnry force-pushed the stretch-tool-only-stretch-hist branch from 3783f63 to efdaec1 Compare November 8, 2023 17:23
@kecnry kecnry added bug Something isn't working trivial Only needs one approval instead of two labels Nov 8, 2023
@kecnry kecnry marked this pull request as ready for review November 8, 2023 17:24
@kecnry kecnry force-pushed the stretch-tool-only-stretch-hist branch from efdaec1 to 058149f Compare November 8, 2023 17:25
Copy link

codecov bot commented Nov 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Files Coverage Δ
...nfigs/default/plugins/plot_options/plot_options.py 91.20% <100.00%> (-0.03%) ⬇️
jdaviz/core/template_mixin.py 91.65% <100.00%> (+0.01%) ⬆️

... and 1 file with indirect coverage changes

📢 Thoughts on this report? Let us know!

@rosteen
Copy link
Collaborator

rosteen commented Nov 8, 2023

I'll admit to still being a little confused about why this was happening in the first place. Were multiple viewers sharing a NestedJupyterToolbar instance?

@kecnry
Copy link
Member Author

kecnry commented Nov 8, 2023

I think because it was defined at the class level, other instances initiated later saw the same changes.

Copy link
Collaborator

@rosteen rosteen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed that the tool is gone in the viewers for line profiles and aperture photometry. Still don't know how it got there in the first place!

@kecnry kecnry merged commit 3d461b6 into spacetelescope:main Nov 8, 2023
@kecnry kecnry deleted the stretch-tool-only-stretch-hist branch November 8, 2023 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working trivial Only needs one approval instead of two
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants