Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HLA-1402: Fix failing pytests #1929

Merged

Conversation

s-goldman
Copy link
Collaborator

@s-goldman s-goldman commented Jan 9, 2025

Resolves HLA-1402

This PR addresses the failing pytests on github actions.

test_align.py:

  • Due to recent changes to the required number of n_matches, some of the expected WCS solutions are no longer valid. One dataset "ib2u12" no longer achieves a GaiaDr2 solution, as a result this dataset has been removed (temporarily commented out) from the test's input list.

test_asn_regress:

  • The test is currently passing when triggered manually using linux or mac. A problem occurs, however, when the test is run using our new github actions tests. When the astrodrizzle call is run, a dependency call to stsci.tools.asnutils.readASNTable fails to read in the association (asn) file. While testing, I was able to confirm that the file is downloaded to the correct location, but it is apparently empty: ValueError: The truth value of an empty array is ambiguous.

Checklist for maintainers

  • added entry in CHANGELOG.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR

Copy link
Collaborator

@mdlpstsci mdlpstsci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once we are up and running on GA and not under pressure for a build, we should discuss which test to improve, add, and/or eliminate!

@s-goldman s-goldman merged commit 7951b66 into spacetelescope:main Jan 9, 2025
18 checks passed
@s-goldman s-goldman deleted the hla-1402_pytest_failing_01_08_25 branch January 9, 2025 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants