-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MNT: Replace ubuntu-20.04 with ubuntu-22.04 #286
Conversation
The hardware that this repo is primarily made for is limited to Python 3.7.6, and the CI is supposed to reflect that, so this won't work. I will be so free to close this PR without merging for now. |
No worries but please be aware that GitHub is actually removing ubuntu-20.04. This is not under our control. That means your workflows will soon break. FYI. |
@pllim thanks for the heads up. Do you have any more precise info about what "soon" means? Thanks! |
This is all explained in actions/runner-images#11101 linked above. We will soon start the deprecation process for Ubuntu 20.04. While the image is being deprecated, you may experience longer queue times during peak usage hours. Deprecation will begin on 2025-02-01 and the image will be fully unsupported by 2025-04-01. |
Thank you very much @pllim! @RemiSoummer fyi since we talked about the versioning mess very recently... |
I am curious why your code is tied into Python 3.7 only. It is past end-of-life and is now exposed to security risks because it is no longer being patched. You are also tied to many old versions of other things because they have also dropped Python 3.7 support in the past few years. If you wish to consult on how to upgrade, I am sure STScI devs will be happy to advise. Good luck. |
Like said above, it's a single piece of hardware that is unsupported beyond a certain Python version. Rest assured that the team is fully aware of the constraints you list, we've been through dependency hell before, but we can't do much when the vendor is behind on their API releases. |
As recommended by actions/runner-images#11101 , this PR replaces the deprecated ubuntu-20.04 runner with a newer version. This also replaces RTD workflow, if applicable, to future-proof the build in case it follows suit.
This is an automated update made by the
batchpr
tool 🤖 - feel free to close if it doesn't look good! You can report issues to @pllim.👻