Finish adding missing service docs #279
Draft
+122
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21 tasks
ivalaginja
commented
Feb 2, 2025
Comment on lines
+10
to
+12
| - Something about command tolerances (TODO) | ||
|
|
||
| - Something about the concrete model used so far with catkit2, on HiCAT. (TODO) |
There was a problem hiding this comment.
@raphaelpclt could you add something to these two points here? I remember you working on the motor tolerances, and you have access to the concrete info about the model HiCAT uses.
ivalaginja
force-pushed
the
feature/last_service_docs
branch
3 times, most recently
from
fa1b9a4 to
a847b40
Compare
ivalaginja
commented
Feb 6, 2025
|
|
||
| Properties | ||
| ---------- | ||
| ``value``: |
There was a problem hiding this comment.
Oh I also need to fill these in, whoops.
There was a problem hiding this comment.
Ah I didn't do that because I didn't fully understood how this service works... Where does the self.check_value[0] in it come from?
ivalaginja
force-pushed
the
feature/last_service_docs
branch
from
a847b40 to
0c7906e
Compare
…ddress and path, then rest
ivalaginja
force-pushed
the
feature/last_service_docs
branch
from
5fdcb1c to
d4fa992
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses last of open service docs listed in #190.