Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor map loading & saving #34020

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Refactor map loading & saving #34020

wants to merge 14 commits into from
+717 −417

Conversation

ElectroJr
Copy link
Member

@ElectroJr ElectroJr commented Dec 23, 2024 •
edited
Loading

Content changes for an engine PR. See the engine PR for details
fixes #12968
fixes #22768
fixes #24079
requires space-wizards/RobustToolbox#5572

@ElectroJr ElectroJr added P3: Standard Priority: Default priority for repository items. T: Refactor Type: Refactor of notable amount of codebase S: Requires Engine PR Status: Requires a change to Robust Toolbox, for which there is no open PR currently. D1: High Difficulty: Extensive codebase knowledge required. A: Mapping Area: Maps, or tools used for mapping labels Dec 23, 2024
@github-actions github-actions bot added S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. S: Needs Review Status: Requires additional reviews before being fully accepted size/M Denotes a PR that changes 100-999 lines. Changes: Map Changes: Might require knowledge of mapping. labels Dec 23, 2024
@ElectroJr ElectroJr mentioned this pull request Dec 23, 2024
Open
@ScarKy0 ScarKy0 removed the S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. label Dec 23, 2024
@ElectroJr ElectroJr mentioned this pull request Dec 27, 2024
Open
16 tasks
@github-actions github-actions bot added the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Jan 7, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 7, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added size/L Denotes a PR that changes 1000-4999 lines. and removed size/M Denotes a PR that changes 100-999 lines. labels Jan 18, 2025
@ElectroJr ElectroJr removed the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@metalgearsloth metalgearsloth Awaiting requested review from metalgearsloth metalgearsloth is a code owner

@Emisse Emisse Awaiting requested review from Emisse Emisse is a code owner

@DrSmugleaf DrSmugleaf Awaiting requested review from DrSmugleaf DrSmugleaf is a code owner

@nikthechampiongr nikthechampiongr Awaiting requested review from nikthechampiongr nikthechampiongr is a code owner

@crazybrain23 crazybrain23 Awaiting requested review from crazybrain23 crazybrain23 is a code owner

Assignees
No one assigned
Labels
A: Mapping Area: Maps, or tools used for mapping Changes: Map Changes: Might require knowledge of mapping. D1: High Difficulty: Extensive codebase knowledge required. P3: Standard Priority: Default priority for repository items. S: Needs Review Status: Requires additional reviews before being fully accepted S: Requires Engine PR Status: Requires a change to Robust Toolbox, for which there is no open PR currently. size/L Denotes a PR that changes 1000-4999 lines. T: Refactor Type: Refactor of notable amount of codebase
Projects
None yet
Milestone
No milestone
2 participants
@ElectroJr @ScarKy0