Conveyor optimisations #33870
Conveyor optimisations #33870
Conversation
- Optimise movement for moving stuff. Better flags + less resolves + slapped parallelrobustjob on it. - Sleeping for entities getting conveyed into walls.
github-actions
bot
added
S: Untriaged
ScarKy0
added
P2: Raised
github-actions
bot
added
size/M
ArtisticRoomba
removed
the
S: Needs Engine PR Merged
…or-opt # Conflicts: # Resources/Prototypes/Entities/Structures/conveyor.yml
github-actions
bot
added
Changes: Map
This reverts commit 1b93fda.
| }; | ||
|
|
||
| var transform = PhysicsSystem.GetLocalPhysicsTransform(entity.Owner, xform); | ||
| transform.Position += direction; |
There was a problem hiding this comment.
Ideally the actual movement would be done by offsetting the velocity and letting the physics system handle the movement instead of teleporting it in very small steps. Because currently if an entity is being conveyed it has a velocity of zero even though it is moving, which might cause problems for other systems which need that info (for example my homing projectile PR I'm working on).
There was a problem hiding this comment.
If a body's InAir ideally it doesn't get conveyed at all (which I imagine a homing projectile would be).
The issue is mob movement entirely dictates the mob's velocity so those systems would need rewriting to handle other input sources.
There was a problem hiding this comment.
The problem is not the projectile (which does not get conveyed), but the velocity of a target object on a conveyor. That relative motion is important for the homing algorithm to be able to intercept.
There was a problem hiding this comment.
I doubt I can cook something up anytime soon as most resources I found on it just adjust position directly because it handles corners better + facilitates not tampering with the CC.
It's just a matter of do we think fixing conveyors tanking the server is more worthwhile than waiting for someone to rewrite conveyor movement as they would have to look at something like velocity sources (which box2d doesn't have innately).
Resources/Maps/bagel.yml
Outdated
| @@ -72,7 +72,7 @@ entities: | |||
| - type: MetaData | |||
There was a problem hiding this comment.
Is this file supposed to be in here?
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
added
the
S: Merge Conflict
github-actions
bot
added
size/M
|
what is the map change for |
Conveyor comp coz something getting conveyed, I can prolly make it not saveable. |
Needs space-wizards/RobustToolbox#5560 + space-wizards/RobustToolbox#5440Needs space-wizards/RobustToolbox#5637I want to give it a shot using shapecasts which will also be a prototype for new mob movement similar to how most games handle it (outside of physics).
Current branch still needs subscribing to airtightchanges or whatever to know if we need to start re-conveying entities.
Resolves #33861