Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qm external access #32631

Merged
merged 2 commits into from
Oct 13, 2024
Merged

Qm external access #32631

merged 2 commits into from
Oct 13, 2024

Conversation

pheenty
Copy link
Contributor

@pheenty pheenty commented Oct 4, 2024

About the PR

Qquartermaster now has external access.

Why / Balance

The quartermaster is the head of cargo, and salvage specialists are their subordinates. If their subordinates have the access, they should have it too. Simple logic and the ability for QM to hire new salvage specialists without asking HoP to give them the external access.

Technical details

Nothing special, just a single line in .yml

Media

image

Requirements

🆑 pheenty

  • add: Quartermaster now has external access

@github-actions github-actions bot added the Changes: No C# Changes: Requires no C# knowledge to review or fix this item. label Oct 4, 2024
@lzk228
Copy link
Contributor

lzk228 commented Oct 4, 2024

makes sense

@K-Dynamic
Copy link
Contributor

QM external access was removed in #21677

However they need externals to hire salvagers once every head gets an ID computer

@slarticodefast slarticodefast self-assigned this Oct 4, 2024
@slarticodefast slarticodefast added the S: Undergoing Maintainer Discussion Status: Currently going through an extended discussion amongst maintainers, as per procedure. label Oct 4, 2024
@slarticodefast
Copy link
Member

Hey, we had a maintainer discussion and vote and decided that it should be fine for the QM since salvagers also have externals access. Thank you for your contribution.

As a side note for anyone reading this: This does not mean the RD or CMO should have externals access as well.

@slarticodefast slarticodefast added the S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. label Oct 9, 2024
@UbaserB UbaserB merged commit 7f42c0a into space-wizards:master Oct 13, 2024
12 checks passed
@pheenty pheenty deleted the qm-external-access branch October 13, 2024 05:22
Doctor-Cpu pushed a commit to Doctor-Cpu/space-station-14 that referenced this pull request Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: No C# Changes: Requires no C# knowledge to review or fix this item. S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. S: Undergoing Maintainer Discussion Status: Currently going through an extended discussion amongst maintainers, as per procedure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants