Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add planet lighting #32522

Merged
merged 42 commits into from
Feb 16, 2025
Merged

Add planet lighting #32522

merged 42 commits into from
Feb 16, 2025

Conversation

metalgearsloth
Copy link
Contributor

@metalgearsloth metalgearsloth commented Sep 29, 2024 •
edited
Loading

Just up here to get help with some stuff still a while out.

Requires space-wizards/RobustToolbox#5490

image

🆑 DoutorWhite & metalgearsloth

  • add: Added planet lighting for indoor / outdoor areas.
  • add: Added day-night cycle functionality.

DoutorWhite and others added 13 commits December 18, 2023 16:56
@Kadeo64
Copy link
Contributor

Kadeo64 commented Sep 29, 2024

europa real??

@metalgearsloth
Copy link
Contributor Author

image

Also did emissive tiles.

At the moment just needs code optimisation + pretty sure shuttles will be broken then it's gucci.

@metalgearsloth
Fixes
19649c0
@metalgearsloth
Merge branch '22719' into 2024-09-29-planet-lighting
9f2785b 
# Conflicts:
#	Content.Server/Parallax/BiomeSystem.cs
#	Content.Server/Salvage/SpawnSalvageMissionJob.cs
#	Resources/Prototypes/Procedural/salvage_mods.yml
@metalgearsloth
Revert "Merge branch '22719' into 2024-09-29-planet-lighting"
2ccce62 
This reverts commit 9f2785b, reversing
changes made to 19649c0.
@metalgearsloth
Europa and day-night
b4065d7
@github-actions github-actions bot added the Changes: Map Changes: Might require knowledge of mapping. label Oct 5, 2024
@metalgearsloth
Copy link
Contributor Author

Nice. Preciate the work on it. Would applying the setroof component to entities work too? Just for more dynamic buildings and destruction I'd be leaning that way personally.

I could probably remove queuedel from it and it would probably work and just make that a separate component. I can probably remove the lookups from the overlay too in lieu of solely relying on tiles.

@chromiumboy
Copy link
Contributor

Will stations get day-night lighting too?

@metalgearsloth
Copy link
Contributor Author

Will stations get day-night lighting too?

I mean we could do it but at the moment no.

@chromiumboy
Copy link
Contributor

chromiumboy commented Oct 17, 2024 •
edited
Loading

I mean we could do it but at the moment no.

Might need to have a maints discussion, since the dark of space is used to hide a lot of antag activity, but I think it would be neat to have the solar panels periodically get some actual sun :)

TheShuEd
TheShuEd approved these changes Oct 22, 2024
View reviewed changes
Copy link
Member

@TheShuEd TheShuEd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool

@SlamBamActionman SlamBamActionman added the S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. label Nov 14, 2024
@eoineoineoin eoineoineoin added P3: Standard Priority: Default priority for repository items. T: New Feature Type: New feature or content, or extending existing content D1: High Difficulty: Extensive codebase knowledge required. S: Needs Review Status: Requires additional reviews before being fully accepted A: Core Tech Area: Underlying core tech for the game and the Github repository. T: Visual Change Type: Deals with changes to art, sprites or other visuals in the game. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Nov 22, 2024
@Pixeltheaertist
Copy link

Planet fork devs checking in on this PR every 15 minutes fr

@DoutorWhite
Copy link
Contributor

is this still alive?

@github-actions github-actions bot added the size/M Denotes a PR that changes 100-999 lines. label Feb 10, 2025
@metalgearsloth
Add sun shadows (planet lighting v2)
90e67b3 
For now mostly targeting walls and having the shadows change over time. Got the basic proof-of-concept working just needs a hell of a lot of polish.
@metalgearsloth
Documentation
4d948b8
@metalgearsloth
a
2cb18fa
@metalgearsloth
Fixes
6b25647
@metalgearsloth
Move blur to an overlay
2d50b93
@metalgearsloth
Slughands
78d4d0f
@metalgearsloth
Fixes
af3e85d
@metalgearsloth
Remove v2 work
8c39d6f
@metalgearsloth
Finalise
e91f43c
@metalgearsloth
Copy link
Contributor Author

is this still alive?

yeah just had to fix some bugs

@metalgearsloth metalgearsloth merged commit b6ee183 into space-wizards:master Feb 16, 2025
12 checks passed
@metalgearsloth metalgearsloth deleted the 2024-09-29-planet-lighting branch February 16, 2025 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheShuEd TheShuEd TheShuEd approved these changes

Assignees
No one assigned
Labels
A: Core Tech Area: Underlying core tech for the game and the Github repository. Changes: Map Changes: Might require knowledge of mapping. D1: High Difficulty: Extensive codebase knowledge required. P3: Standard Priority: Default priority for repository items. S: Needs Review Status: Requires additional reviews before being fully accepted size/M Denotes a PR that changes 100-999 lines. T: New Feature Type: New feature or content, or extending existing content T: Visual Change Type: Deals with changes to art, sprites or other visuals in the game.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@metalgearsloth @Kadeo64 @Peptide90 @DoutorWhite @rbertoche @chromiumboy @Pixeltheaertist @TheShuEd @eoineoineoin @SlamBamActionman