Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add map and grid prototypes #31665

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

deltanedas
Copy link
Contributor

About the PR

adds Map, MapAtmos, MapAtmosCold, MapGrid, MapGridAnchored prototypes
anchored only used downstream right now but could be useful for station anchor pr

Why / Balance

resolves #30999

Media

shittle works

Requirements

  • I have read and I am following the Pull Request Guidelines. I understand that not doing so may get my pr closed at maintainer’s discretion
  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

no

Changelog
no cl no fun

Sorry, something went wrong.

@github-actions github-actions bot added the Changes: No C# Changes: Requires no C# knowledge to review or fix this item. label Aug 31, 2024
@deltanedas
Copy link
Contributor Author

how do i prevent all tests from trying to spawn them, they should be abstract but map doesnt count as inheriting it

@SlamBamActionman SlamBamActionman added the S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. label Nov 14, 2024
@eoineoineoin eoineoineoin added P3: Standard Priority: Default priority for repository items. T: New Feature Type: New feature or content, or extending existing content D3: Low Difficulty: Some codebase knowledge required. S: Needs Review Status: Requires additional reviews before being fully accepted A: Mapping Area: Maps, or tools used for mapping and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Nov 22, 2024
@ElectroJr ElectroJr self-assigned this Dec 27, 2024
@ElectroJr
Copy link
Member

ElectroJr commented Dec 28, 2024

The base map prototype that just has all the components that the engine's mapping system adds automatically to all maps should just be an engine prototype. I'll open an engine PR for that then try help with whatever the test issue was. Actually it probably requires some map system changes that would conflict with space-wizards/RobustToolbox/pull/5572 so ill wait for now

@deltanedas deltanedas marked this pull request as draft December 28, 2024 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: Mapping Area: Maps, or tools used for mapping Changes: No C# Changes: Requires no C# knowledge to review or fix this item. D3: Low Difficulty: Some codebase knowledge required. P3: Standard Priority: Default priority for repository items. S: Needs Review Status: Requires additional reviews before being fully accepted T: New Feature Type: New feature or content, or extending existing content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

need map entity prototypes
4 participants