Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firmware keys #23097

Closed
wants to merge 7 commits into from
Closed

Firmware keys #23097

wants to merge 7 commits into from

Conversation

Tornado-Technology
Copy link
Contributor

@Tornado-Technology Tornado-Technology commented Dec 28, 2023

About the PR

Added new "Firmware keys" items that allow you to change the effect of Emag.

The keys can be found in the research director's closet, or made on the protolate when studying the corresponding technology.
image

To activate, you need to go to the hacked object and click on it with the key, after which DoAfter will start, after which the desired item will be repaired, and you will be happy with the work done. I would like to note that the key will be spent.

There is also an advanced version of the key, which is not spent when used, but for now it can only be spawned through the entity spawn panel.

Why / Balance

You can do this with most items, but it requires a long reset, and it doesn’t always help. But we may lose the items we need or the hacking device cannot be reassembled.

Therefore, keys have been added that need to be studied and created to cancel the effect.

There is also an advanced key, it could have been given to the scientific supervisor as a high-risk item, but this sounds very dishonest. Therefore, it is simply not used yet, and its difference is that it is not wasted.

Technical details

Some systems such as Access, Lock, etc. They require direct intervention in the code, because to cancel an action it is not enough to simply remove the Emagged component.

As I refine it, I will describe below what I changed in each system:

  • BedSystem
  • DisposalUnitSystem (Changed)
  • FireAlarmSystem
  • ReagentDispenserSystem (Changed)
  • CloningSystem
  • DoorSystem
  • FaxSystem
  • SmokingSystem
  • UnpoweredFlashlightSystem
  • FatExtractorSystem
  • ApcSystem
  • SiliconLawSystem
  • VendingMachineSystem
  • AccessReaderSystem
  • SharedDisposalUnitSystem
  • SharedLatheSystem
  • LockSystem
  • SharedMaterialReclaimerSystem
  • SharedCryoPodSystem (Changed)
  • SharedPinpointerSystem (Changed)
  • MedibotSystem (Changed)
  • SharedSiliconLawSystem (Changed)

Media

firmware.mp4
  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

No

Changelog
🆑

  • add: Added new item "firmware key", it allows you to cancel the effect of Emag, but it is wasted. You can find keys either in the RD locker or study "Fast Firmware" T2 technology.

@github-actions github-actions bot added the Changes: Sprites Changes: Might require knowledge of spriting or visual design. label Dec 28, 2023
Copy link
Contributor

github-actions bot commented Dec 28, 2023

RSI Diff Bot; head commit 313a4a7 merging into 019db5a
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Objects/Devices/firmware_key.rsi

State Old New Status
advanced Added
icon Added

Edit: diff updated after 313a4a7

@Admiral-Obvious-001
Copy link
Contributor

This one looks cool and would be so useful for so many things.

@github-actions github-actions bot added the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Jan 5, 2024
Copy link
Contributor

github-actions bot commented Jan 5, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@dvir001
Copy link
Contributor

dvir001 commented Jan 11, 2024

@Tornado-Technology It seems we were working on the same code by mistake, but at the same time I was working on the parts you are missing

You can credit and use the DoorSystem and LockSystem code I made as it seems you are missing the 2 from your PR.
Hope this helps

new-frontiers-14/frontier-station-14#824

@metalgearsloth
Copy link
Contributor

Re-open if you come back to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Sprites Changes: Might require knowledge of spriting or visual design. S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants