Minor PVS stuff #4573
Merged
Minor PVS stuff #4573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The array one is probably most risky in terms of re-using old data but all the array entries are getting cleared every tick (PVSData is only used inside of PVS)
|
The changes seem to be aimed at optimization, and the overall approach looks reasonable. I approve. |
ElectroJr
reviewed
Nov 19, 2023
ElectroJr
reviewed
Nov 19, 2023
|
See metalgearsloth#5 |
… into moar_pvs_pool
Remove _previousIndices and re-use viewer arrays
ElectroJr
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The array one is probably most risky in terms of re-using old data but all the array entries are getting cleared every tick (PVSData is only used inside of PVS)