-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(i): Test benchmark current local acp operations #3396
test(i): Test benchmark current local acp operations #3396
Conversation
3a89bf5
to
ecc4a51
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3396 +/- ##
===========================================
+ Coverage 78.14% 78.34% +0.21%
===========================================
Files 392 392
Lines 36045 36045
===========================================
+ Hits 28164 28239 +75
+ Misses 6201 6149 -52
+ Partials 1680 1657 -23
Flags with carried forward coverage won't be shown. Click here to find out more. see 16 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
0dae79d
to
ba38cb4
Compare
ba38cb4
to
cc9187e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one todo to remove commented out code.
One thing that would be nice is maybe instead of having the commit as part of the title, I would prefer having the date of the commit (acp_bench_report_20250114.md) so that the files can be ordered sequentially. The commit is mentioned at the top of the documentation so it will always be easy to refer to it if needed.
DID: "did:key:z7r8os2G88XXBNBTLj3kFR5rzUJ4VAesbX7PgsA68ak9B5RYcXF5EZEmjRzzinZndPSSwujXb4XKHG6vmKEFG6ZfsfcQn", | ||
} | ||
|
||
//var identity2 = identity.Identity{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
todo: Please remove commented code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I want to keep it for now. I was benching a few other acp ops that I need it for (relationship stuff).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, nice job Shahzad
I like this suggestion, will do! |
Relevant issue(s)
Resolves #3389
Description
register
callcheck
callis object registered?
callBenchmarking Reports:
TLDR Comparisons of Old vs New:
Register:
CheckDocAccess:
IsDocRegistered: