Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Allow test harness to execute benchmarks #2740

Merged

Conversation

AndrewSisley
Copy link
Contributor

@AndrewSisley AndrewSisley commented Jun 18, 2024

Relevant issue(s)

Resolves #2739

Description

Allows test harness to execute benchmark tests as well as normal-tests.

Broken out of #2545 - is a good change independent of that though anyway and will allow us to use the integration test actions in benchmarks.

@AndrewSisley AndrewSisley added the area/testing Related to any test or testing suite label Jun 18, 2024
@AndrewSisley AndrewSisley added this to the DefraDB v0.12 milestone Jun 18, 2024
@AndrewSisley AndrewSisley requested a review from a team June 18, 2024 20:52
@AndrewSisley AndrewSisley self-assigned this Jun 18, 2024
@AndrewSisley AndrewSisley force-pushed the 2739-harness-benches-too branch from 98a3def to 5b64707 Compare June 18, 2024 20:53
Copy link

codecov bot commented Jun 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.06%. Comparing base (6573d8c) to head (5b64707).

Current head 5b64707 differs from pull request most recent head 91f125b

Please upload reports for the commit 91f125b to get more accurate results.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2740      +/-   ##
===========================================
- Coverage    78.09%   78.06%   -0.03%     
===========================================
  Files          311      310       -1     
  Lines        23235    23185      -50     
===========================================
- Hits         18144    18098      -46     
+ Misses        3707     3702       -5     
- Partials      1384     1385       +1     
Flag Coverage Δ
all-tests 78.06% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 14 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6573d8c...91f125b. Read the comment docs.

@AndrewSisley AndrewSisley changed the title test: Allow test execute benchmarks as well as tests test: Allow test harness to execute benchmarks as well as tests Jun 18, 2024
@AndrewSisley AndrewSisley changed the title test: Allow test harness to execute benchmarks as well as tests test: Allow test harness to execute benchmarks Jun 18, 2024
Copy link
Collaborator

@fredcarle fredcarle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Looking forward to see how you intend to use this change.

@AndrewSisley AndrewSisley force-pushed the 2739-harness-benches-too branch from 5b64707 to 91f125b Compare June 19, 2024 20:43
@AndrewSisley AndrewSisley merged commit e3eca29 into sourcenetwork:develop Jun 19, 2024
35 of 36 checks passed
@AndrewSisley AndrewSisley deleted the 2739-harness-benches-too branch June 19, 2024 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing Related to any test or testing suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow test harness to execute benchmarks
2 participants