-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(i): Add action to ensure tidyness #2697
ci(i): Add action to ensure tidyness #2697
Conversation
22fdde8
to
ab01887
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2697 +/- ##
===========================================
+ Coverage 77.97% 78.00% +0.03%
===========================================
Files 308 308
Lines 23134 23134
===========================================
+ Hits 18038 18045 +7
+ Misses 3714 3710 -4
+ Partials 1382 1379 -3
Flags with carried forward coverage won't be shown. Click here to find out more. see 7 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
make tidy
is not brokenmake tidy
4d7b37d
to
9bbe989
Compare
make tidy
make tidy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but please check my thought before deciding whether to merge or not
make tidy
Relevant issue(s)
Resolves ##2695
Description
Backstory
There are 2 things being checked within the new added action:
make tidy
isn't broken).make tidy
is ran and up to date.NOTE:
(2)
above I am not sure if we want to keep, or not I would be okay with just(1)
. However here are some reasons why you would want(2)
:tidy state
How has this been tested?
Action that failed when
make tidy
was broken: https://github.com/sourcenetwork/defradb/actions/runs/9422665720/job/25959440810?pr=2697Action that failed when
make tidy
was not up to date (i.e. not tidy):https://github.com/sourcenetwork/defradb/actions/runs/9422726089/job/25959622978?pr=2697
Specify the platform(s) on which this was tested: