Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(i): Add action to ensure tidyness #2697

Conversation

shahzadlone
Copy link
Member

@shahzadlone shahzadlone commented Jun 7, 2024

Relevant issue(s)

Resolves ##2695

Description

Backstory

There are 2 things being checked within the new added action:

  1. That the backstory doesn't happen again (make tidy isn't broken).
  2. make tidy is ran and up to date.

NOTE: (2) above I am not sure if we want to keep, or not I would be okay with just (1). However here are some reasons why you would want (2):

  • always be in tidy state
  • one less command to do at release stage.

How has this been tested?

Specify the platform(s) on which this was tested:

  • WSL2

@shahzadlone shahzadlone force-pushed the lone/ci/ensure-go-mody-tidy-is-not-broken branch from 22fdde8 to ab01887 Compare June 7, 2024 20:18
Copy link

codecov bot commented Jun 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.00%. Comparing base (343b90a) to head (9bbe989).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2697      +/-   ##
===========================================
+ Coverage    77.97%   78.00%   +0.03%     
===========================================
  Files          308      308              
  Lines        23134    23134              
===========================================
+ Hits         18038    18045       +7     
+ Misses        3714     3710       -4     
+ Partials      1382     1379       -3     
Flag Coverage Δ
all-tests 78.00% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 7 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 343b90a...9bbe989. Read the comment docs.

@shahzadlone shahzadlone changed the title ci(i): Add action that ensures make tidy is not broken ci(i): Add action to check make tidy Jun 7, 2024
@shahzadlone shahzadlone force-pushed the lone/ci/ensure-go-mody-tidy-is-not-broken branch from 4d7b37d to 9bbe989 Compare June 7, 2024 21:12
@shahzadlone shahzadlone added the ci/build This is issue is about the build or CI system, and the administration of it. label Jun 7, 2024
@shahzadlone shahzadlone self-assigned this Jun 7, 2024
@shahzadlone shahzadlone requested a review from a team June 7, 2024 21:13
@shahzadlone shahzadlone changed the title ci(i): Add action to check make tidy ci(i): Add action to check make tidy Jun 7, 2024
@shahzadlone shahzadlone changed the title ci(i): Add action to check make tidy ci(i): Add action to check make tidy Jun 7, 2024
Copy link
Contributor

@AndrewSisley AndrewSisley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please check my thought before deciding whether to merge or not

@shahzadlone shahzadlone added this to the DefraDB v0.12 milestone Jun 10, 2024
@shahzadlone shahzadlone changed the title ci(i): Add action to check make tidy ci(i): Add action to ensure tidyness Jun 10, 2024
@shahzadlone shahzadlone merged commit 067e378 into sourcenetwork:develop Jun 10, 2024
40 of 42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/build This is issue is about the build or CI system, and the administration of it.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants