remove unecessary type casting check

internal/request/graphql/schema/collection.go

@@ -629,52 +629,20 @@ func embeddingFromAST(directive *ast.Directive, fieldDef *ast.FieldDefinition) (
 	for _, arg := range directive.Arguments {
 		switch arg.Name.Value {
 		case types.EmbeddingDirectivePropFields:
-			val, ok := arg.Value.(*ast.ListValue)
-			if !ok {
-				return client.EmbeddingDescription{},
-					NewErrEmbeddingInvalidProp[[]string](types.ConstraintsDirectivePropSize, arg.Value.GetValue())
-			}
+			val := arg.Value.(*ast.ListValue)
 			fields := make([]string, len(val.Values))
 			for i, untypedField := range val.Values {
-				field, ok := untypedField.(*ast.StringValue)
-				if !ok {
-					return client.EmbeddingDescription{},
-						NewErrEmbeddingInvalidProp[[]string](types.ConstraintsDirectivePropSize, field.GetValue())
-				}
-				fields[i] = field.Value
+				fields[i] = untypedField.(*ast.StringValue).Value
 			}
 			embedding.Fields = fields
 		case types.EmbeddingDirectivePropModel:
-			val, ok := arg.Value.(*ast.StringValue)
-			if !ok {
-				return client.EmbeddingDescription{},
-					NewErrEmbeddingInvalidProp[string](types.EmbeddingDirectivePropModel, arg.Value.GetValue())
-			}
-			embedding.Model = val.Value
+			embedding.Model = arg.Value.(*ast.StringValue).Value
 		case types.EmbeddingDirectivePropProvider:
-			val, ok := arg.Value.(*ast.StringValue)
-			if !ok {
-				return client.EmbeddingDescription{},
-					NewErrEmbeddingInvalidProp[string](types.EmbeddingDirectivePropProvider, arg.Value.GetValue())
-			}
-			embedding.Provider = val.Value
+			embedding.Provider = arg.Value.(*ast.StringValue).Value
 		case types.EmbeddingDirectivePropTemplate:
-			val, ok := arg.Value.(*ast.StringValue)
-			if !ok {
-				return client.EmbeddingDescription{},
-					NewErrEmbeddingInvalidProp[string](types.EmbeddingDirectivePropTemplate, arg.Value.GetValue())
-			}
-			embedding.Template = val.Value
+			embedding.Template = arg.Value.(*ast.StringValue).Value
 		case types.EmbeddingDirectivePropURL:
-			val, ok := arg.Value.(*ast.StringValue)
-			if !ok {
-				return client.EmbeddingDescription{},
-					NewErrEmbeddingInvalidProp[string](types.EmbeddingDirectivePropURL, arg.Value.GetValue())
-			}
-			embedding.URL = val.Value
-		default:
-			return client.EmbeddingDescription{},
-				NewErrDirectiveWithUnknownArg(types.ConstraintsDirectiveLabel, arg.Name.Value)
+			embedding.URL = arg.Value.(*ast.StringValue).Value
 		}
 	}
 	return embedding, nil
@@ -692,19 +660,11 @@ func contraintsFromAST(kind client.FieldKind, directive *ast.Directive) (constra
 			if !kind.IsArray() {
 				return constraintDescription{}, NewErrInvalidTypeForContraint(kind)
 			}
-			val, ok := arg.Value.(*ast.IntValue)
-			if !ok {
-				return constraintDescription{},
-					NewErrContraintsInvalidProp[int](types.ConstraintsDirectivePropSize, arg.Value.GetValue())
-			}
-			size, err := strconv.Atoi(val.Value)
+			size, err := strconv.Atoi(arg.Value.(*ast.IntValue).Value)
 			if err != nil {
 				return constraintDescription{}, err
 			}
 			constraints.Size = size
-		default:
-			return constraintDescription{},
-				NewErrDirectiveWithUnknownArg(types.ConstraintsDirectiveLabel, arg.Name.Value)
 		}
 	}
 	return constraints, nil

internal/request/graphql/schema/errors.go

@@ -11,8 +11,6 @@
 package schema
 
 import (
-	"fmt"
-
 	"github.com/sourcenetwork/defradb/client"
 	"github.com/sourcenetwork/defradb/errors"
 )
@@ -40,10 +38,7 @@ const (
 	errDefaultValueInvalid           string = "default value is invalid"
 	errDefaultValueOneArg            string = "default value must specify one argument"
 	errFieldTypeNotSpecified         string = "field type not specified"
-	errDirectiveWithUnknownArg       string = "directive with unknown argument"
-	errConstraintsInvalidProp        string = "constraints directive with invalid property"
 	errInvalidTypeForContraint       string = "size constraint can only be applied to array fields"
-	errEmbeddingInvalidProp          string = "embedding directive with invalid property"
 )
 
 var (
@@ -71,9 +66,6 @@ var (
 	ErrPolicyInvalidIDProp       = errors.New(errPolicyInvalidIDProp)
 	ErrPolicyInvalidResourceProp = errors.New(errPolicyInvalidResourceProp)
 	ErrFieldTypeNotSpecified     = errors.New(errFieldTypeNotSpecified)
-	ErrrDirectiveWithUnknownArg  = errors.New(errDirectiveWithUnknownArg)
-	ErrConstraintsInvalidSize    = errors.New(errConstraintsInvalidProp)
-	ErrEmbedingInvalidSize       = errors.New(errEmbeddingInvalidProp)
 	ErrInvalidTypeForContraint   = errors.New(errInvalidTypeForContraint)
 )
 
@@ -196,34 +188,6 @@ func NewErrFieldTypeNotSpecified(objectName, fieldName string) error {
 	)
 }
 
-func NewErrDirectiveWithUnknownArg(directive, arg string) error {
-	return errors.New(
-		errDirectiveWithUnknownArg,
-		errors.NewKV("Directive", directive),
-		errors.NewKV("Argument", arg),
-	)
-}
-
-func NewErrContraintsInvalidProp[TExpected any](name string, actual any) error {
-	var expected TExpected
-	return errors.New(
-		errConstraintsInvalidProp,
-		errors.NewKV("Prop", name),
-		errors.NewKV("Expected", fmt.Sprintf("%T", expected)),
-		errors.NewKV("Actual", fmt.Sprintf("%T", actual)),
-	)
-}
-
-func NewErrEmbeddingInvalidProp[TExpected any](name string, actual any) error {
-	var expected TExpected
-	return errors.New(
-		errEmbeddingInvalidProp,
-		errors.NewKV("Prop", name),
-		errors.NewKV("Expected", fmt.Sprintf("%T", expected)),
-		errors.NewKV("Actual", fmt.Sprintf("%T", actual)),
-	)
-}
-
 func NewErrInvalidTypeForContraint(actual client.FieldKind) error {
 	return errors.New(errInvalidTypeForContraint, errors.NewKV("Actual", actual.String()))
 }