Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor!: rename frame command to inspect #224

Merged
merged 2 commits into from
Feb 12, 2025
Merged

refactor!: rename frame command to inspect #224

merged 2 commits into from
Feb 12, 2025

Conversation

bavulapati
Copy link
Contributor

@bavulapati bavulapati commented Feb 8, 2025 •
edited
Loading

BREAKING CHANGE: inspect command is now used instead of frame

closes #223

@bavulapati bavulapati force-pushed the rename-frame-to-inspect branch from b3aa1ca to 039427f Compare February 8, 2025 07:07
@jviotti
Copy link
Member

jviotti commented Feb 9, 2025

Looks good but let's avoid touching dependencies. The idea is to only rename the command, and make it cover various analysis cases, including framing.

jviotti
jviotti requested changes Feb 9, 2025
View reviewed changes
Copy link
Member

@jviotti jviotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's only rename in this project. No need to do any other rename!

@bavulapati bavulapati force-pushed the rename-frame-to-inspect branch from 91c1b49 to 342fad1 Compare February 10, 2025 02:18
@bavulapati bavulapati requested a review from jviotti February 10, 2025 02:23
@jviotti
Copy link
Member

jviotti commented Feb 10, 2025

Almost there! Can you update the README which points to frame docs and docs/frame.markdown too?

@bavulapati
Copy link
Contributor Author

Almost there! Can you update the README which points to frame docs and docs/frame.markdown too?

Do we still call the reconnaissance process framing?

@bavulapati bavulapati force-pushed the rename-frame-to-inspect branch from 7b3aee1 to b15767f Compare February 10, 2025 14:44
@jviotti
Copy link
Member

jviotti commented Feb 10, 2025

@bavulapati Yeah, let's keep that and just change the frame command mention to inspect

@bavulapati
Copy link
Contributor Author

@bavulapati Yeah, let's keep that and just change the frame command mention to inspect

done. PTAL

@jviotti
Copy link
Member

jviotti commented Feb 10, 2025

@bavulapati Looks like there is a minor conflict with a hot fix I did today. Can you rebase?

@bavulapati
refactor!: rename frame command to inspect
b637f6b 
BREAKING CHANGE: inspect command is now used instead of frame
closes sourcemeta#223

Signed-off-by: Balakrishna Avulapati <[email protected]>
@bavulapati
refactor: rename analyse command to inspect in the docs
fe1c0e5 
Signed-off-by: Balakrishna Avulapati <[email protected]>
@bavulapati bavulapati force-pushed the rename-frame-to-inspect branch from b15767f to fe1c0e5 Compare February 10, 2025 23:32
@bavulapati
Copy link
Contributor Author

@jviotti I don't see a merge button on this PR. If this PR looks good, please merge.

@jviotti jviotti merged commit c35e1b0 into sourcemeta:main Feb 12, 2025
7 checks passed
@bavulapati bavulapati deleted the rename-frame-to-inspect branch February 12, 2025 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jviotti jviotti jviotti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename the frame command to inspect
2 participants
@bavulapati @jviotti