Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken instance locations on orphan parent schemas #1538

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jviotti
Copy link
Member

@jviotti jviotti commented Feb 8, 2025

Signed-off-by: Juan Cruz Viotti [email protected]

@jviotti jviotti force-pushed the orphan-parent-broken branch 3 times, most recently from 79a4565 to 42a77f6 Compare February 8, 2025 02:42
@jviotti jviotti force-pushed the orphan-parent-broken branch from 42a77f6 to 0ed7420 Compare February 8, 2025 02:45
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (linux/llvm)

Benchmark suite Current: 42a77f6 Previous: 7af0ac4 Ratio
Regex_Lower_S_Or_Upper_S_Asterisk 2.1866249726653986 ns/iter 2.2016848605821324 ns/iter 0.99
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar 2.183146064657354 ns/iter 2.2122037550403286 ns/iter 0.99
Regex_Period_Asterisk 2.1917600926284853 ns/iter 2.197024436925915 ns/iter 1.00
Regex_Group_Period_Asterisk_Group 2.1830885858115043 ns/iter 2.204678250981296 ns/iter 0.99
Regex_Period_Plus 2.489040808896017 ns/iter 2.4459145036112138 ns/iter 1.02
Regex_Period 2.4885053130579475 ns/iter 2.3135348159790605 ns/iter 1.08
Regex_Caret_Period_Plus_Dollar 2.4857250249886165 ns/iter 2.225338321546048 ns/iter 1.12
Regex_Caret_Group_Period_Plus_Group_Dollar 2.4876916930071533 ns/iter 2.3179633966928828 ns/iter 1.07
Regex_Caret_Period_Asterisk_Dollar 2.182701342886651 ns/iter 2.4872689103963928 ns/iter 0.88
Regex_Caret_Group_Period_Asterisk_Group_Dollar 2.175743028844007 ns/iter 2.491186810649949 ns/iter 0.87
Regex_Caret_X_Hyphen 12.472839818209376 ns/iter 13.053492739771393 ns/iter 0.96
Regex_Period_Md_Dollar 73.75196819025638 ns/iter 73.54778183649483 ns/iter 1.00
Regex_Caret_Slash_Period_Asterisk 6.219215918223201 ns/iter 5.9078561306911475 ns/iter 1.05
Regex_Caret_Period_Range_Dollar 3.7277232777284013 ns/iter 2.531660594469445 ns/iter 1.47
Regex_Nested_Backtrack 495.8199747626698 ns/iter 496.26279826212215 ns/iter 1.00
JSON_Array_Of_Objects_Unique 403.4576742221778 ns/iter 403.20638983298534 ns/iter 1.00
JSON_Parse_1 30551.44653978594 ns/iter 30202.940147370315 ns/iter 1.01
JSON_Fast_Hash_Helm_Chart_Lock 59.34503446038637 ns/iter 60.04241273006841 ns/iter 0.99
JSON_Equality_Helm_Chart_Lock 151.2048803605826 ns/iter 156.8029166343058 ns/iter 0.96
JSON_String_Equal/10 7.849052017498569 ns/iter 7.158470155746318 ns/iter 1.10
JSON_String_Equal/100 8.398405927448534 ns/iter 7.792502310950593 ns/iter 1.08
JSON_String_Equal_Small_By_Perfect_Hash/10 0.9367345653577244 ns/iter 0.9384644965335903 ns/iter 1.00
JSON_String_Equal_Small_By_Runtime_Perfect_Hash/10 10.258770700782252 ns/iter 10.341300695704716 ns/iter 0.99
JSON_String_Fast_Hash/10 2.210564919284503 ns/iter 2.179825718686123 ns/iter 1.01
JSON_String_Fast_Hash/100 2.1772927348159223 ns/iter 2.1779019265145196 ns/iter 1.00
JSON_String_Key_Hash/10 2.4915119358913165 ns/iter 2.489610605396717 ns/iter 1.00
JSON_String_Key_Hash/100 2.1978941934522562 ns/iter 2.178593246629164 ns/iter 1.01
JSON_Object_Defines_Miss_Same_Length 3.768476921451432 ns/iter 3.734350799226504 ns/iter 1.01
JSON_Object_Defines_Miss_Too_Small 3.7354588378825078 ns/iter 3.7349963743660233 ns/iter 1.00
JSON_Object_Defines_Miss_Too_Large 3.7428420451760913 ns/iter 3.738593499592735 ns/iter 1.00
Pointer_Object_Traverse 45.70080822907054 ns/iter 44.395053382997475 ns/iter 1.03
Pointer_Object_Try_Traverse 52.343658044629265 ns/iter 52.36138153142883 ns/iter 1.00
Pointer_Push_Back_Pointer_To_Weak_Pointer 387.5118263990623 ns/iter 304.13267144565225 ns/iter 1.27
Schema_Frame_OMC_Full 328272608.50001496 ns/iter 231886117.6666663 ns/iter 1.42
Schema_Bundle_Meta_2020_12 10392541.23880445 ns/iter 10320976.088215329 ns/iter 1.01

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (macos/llvm)

Benchmark suite Current: 42a77f6 Previous: 7af0ac4 Ratio
Regex_Lower_S_Or_Upper_S_Asterisk 2.1418892355290637 ns/iter 1.6224819433043385 ns/iter 1.32
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar 2.7695060874083417 ns/iter 1.6940436422852294 ns/iter 1.63
Regex_Period_Asterisk 2.1256048929314693 ns/iter 1.7148344927801409 ns/iter 1.24
Regex_Group_Period_Asterisk_Group 2.065244928355043 ns/iter 1.688890574292906 ns/iter 1.22
Regex_Period_Plus 2.424026437069149 ns/iter 2.3704901996831973 ns/iter 1.02
Regex_Period 2.305652057354527 ns/iter 1.994078644788617 ns/iter 1.16
Regex_Caret_Period_Plus_Dollar 2.588926827822997 ns/iter 1.9619568309995605 ns/iter 1.32
Regex_Caret_Group_Period_Plus_Group_Dollar 3.3204372578732326 ns/iter 2.0198317190614588 ns/iter 1.64
Regex_Caret_Period_Asterisk_Dollar 2.329663178062639 ns/iter 1.6476067783304817 ns/iter 1.41
Regex_Caret_Group_Period_Asterisk_Group_Dollar 2.540501086250981 ns/iter 1.6427012066892748 ns/iter 1.55
Regex_Caret_X_Hyphen 8.287991223660987 ns/iter 7.064018820546775 ns/iter 1.17
Regex_Period_Md_Dollar 95.52961489204252 ns/iter 69.88152046029181 ns/iter 1.37
Regex_Caret_Slash_Period_Asterisk 8.28536427268725 ns/iter 5.384410355460009 ns/iter 1.54
Regex_Caret_Period_Range_Dollar 2.8847659113514474 ns/iter 2.3056280567043084 ns/iter 1.25
Regex_Nested_Backtrack 930.0838662184382 ns/iter 768.3572230944129 ns/iter 1.21
JSON_Array_Of_Objects_Unique 359.66903352156226 ns/iter 345.6524230917707 ns/iter 1.04
JSON_Parse_1 23995.52378858957 ns/iter 22424.520311295004 ns/iter 1.07
JSON_Fast_Hash_Helm_Chart_Lock 52.95283597343482 ns/iter 52.03812499999003 ns/iter 1.02
JSON_Equality_Helm_Chart_Lock 131.16777850103537 ns/iter 126.65356694862402 ns/iter 1.04
JSON_String_Equal/10 8.602756485118265 ns/iter 8.008604472036202 ns/iter 1.07
JSON_String_Equal/100 7.217097489974732 ns/iter 6.303887360926132 ns/iter 1.14
JSON_String_Equal_Small_By_Perfect_Hash/10 0.44533489652391456 ns/iter 0.33831854798275685 ns/iter 1.32
JSON_String_Equal_Small_By_Runtime_Perfect_Hash/10 4.052693812402353 ns/iter 3.371496207591341 ns/iter 1.20
JSON_String_Fast_Hash/10 2.40930285832774 ns/iter 2.163812277757084 ns/iter 1.11
JSON_String_Fast_Hash/100 2.6206375898712633 ns/iter 2.028562790605224 ns/iter 1.29
JSON_String_Key_Hash/10 1.8464015941814844 ns/iter 1.3942661796187665 ns/iter 1.32
JSON_String_Key_Hash/100 1.9108677500965607 ns/iter 1.46730211479012 ns/iter 1.30
JSON_Object_Defines_Miss_Same_Length 3.3663651901526865 ns/iter 2.44998613152187 ns/iter 1.37
JSON_Object_Defines_Miss_Too_Small 3.555693252386179 ns/iter 2.373510032779047 ns/iter 1.50
JSON_Object_Defines_Miss_Too_Large 3.2807171343733685 ns/iter 2.3908946623470655 ns/iter 1.37
Pointer_Object_Traverse 25.667079401591693 ns/iter 16.035594725431686 ns/iter 1.60
Pointer_Object_Try_Traverse 40.542075159137184 ns/iter 22.984588806489022 ns/iter 1.76
Pointer_Push_Back_Pointer_To_Weak_Pointer 258.10301872464026 ns/iter 178.5323789847378 ns/iter 1.45
Schema_Frame_OMC_Full 365380291.50000286 ns/iter 175609916.75000536 ns/iter 2.08
Schema_Bundle_Meta_2020_12 14593568.862071136 ns/iter 7883040.741936012 ns/iter 1.85

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (windows/msvc)

Benchmark suite Current: 42a77f6 Previous: 7af0ac4 Ratio
Regex_Lower_S_Or_Upper_S_Asterisk 6.73071607142869 ns/iter 6.737515625001578 ns/iter 1.00
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar 6.574615178571719 ns/iter 6.522985491072473 ns/iter 1.01
Regex_Period_Asterisk 6.530293750000534 ns/iter 6.727327008927578 ns/iter 0.97
Regex_Group_Period_Asterisk_Group 6.812946428571871 ns/iter 6.624167410715285 ns/iter 1.03
Regex_Period_Plus 6.867426339285387 ns/iter 6.892159598214574 ns/iter 1.00
Regex_Period 6.899776785714502 ns/iter 6.9398482142852504 ns/iter 0.99
Regex_Caret_Period_Plus_Dollar 6.915131696428085 ns/iter 7.459502645270188 ns/iter 0.93
Regex_Caret_Group_Period_Plus_Group_Dollar 6.922169642856905 ns/iter 7.118878348213136 ns/iter 0.97
Regex_Caret_Period_Asterisk_Dollar 6.846632142857142 ns/iter 6.5875178571417345 ns/iter 1.04
Regex_Caret_Group_Period_Asterisk_Group_Dollar 6.558775892856821 ns/iter 6.723348214285758 ns/iter 0.98
Regex_Caret_X_Hyphen 14.412071587446706 ns/iter 14.402432748204149 ns/iter 1.00
Regex_Period_Md_Dollar 151.40493303571796 ns/iter 141.9136208967464 ns/iter 1.07
Regex_Caret_Slash_Period_Asterisk 10.044019642858107 ns/iter 9.967823437499133 ns/iter 1.01
Regex_Caret_Period_Range_Dollar 7.267271205358179 ns/iter 7.427206473212981 ns/iter 0.98
Regex_Nested_Backtrack 588.5314285714165 ns/iter 602.7096000000256 ns/iter 0.98
JSON_Array_Of_Objects_Unique 411.30030753122594 ns/iter 411.9514682165134 ns/iter 1.00
JSON_Parse_1 80879.28217490626 ns/iter 79098.12500001477 ns/iter 1.02
JSON_Fast_Hash_Helm_Chart_Lock 54.97632000000294 ns/iter 57.02489285714104 ns/iter 0.96
JSON_Equality_Helm_Chart_Lock 190.87024492432263 ns/iter 188.4037936074258 ns/iter 1.01
JSON_String_Equal/10 9.638598171256717 ns/iter 9.356232547514413 ns/iter 1.03
JSON_String_Equal/100 9.950045044865508 ns/iter 9.930699999998183 ns/iter 1.00
JSON_String_Equal_Small_By_Perfect_Hash/10 2.1684956249998777 ns/iter 2.169586249999611 ns/iter 1.00
JSON_String_Equal_Small_By_Runtime_Perfect_Hash/10 14.69553743439492 ns/iter 14.603738839283103 ns/iter 1.01
JSON_String_Fast_Hash/10 3.097125000000034 ns/iter 3.1469615674177773 ns/iter 0.98
JSON_String_Fast_Hash/100 3.094544196428676 ns/iter 3.154263392857055 ns/iter 0.98
JSON_String_Key_Hash/10 7.69115178571462 ns/iter 7.738637276786571 ns/iter 0.99
JSON_String_Key_Hash/100 3.724165171921132 ns/iter 3.719268743358629 ns/iter 1.00
JSON_Object_Defines_Miss_Same_Length 4.037410587566612 ns/iter 4.027115051834203 ns/iter 1.00
JSON_Object_Defines_Miss_Too_Small 3.4150727617587004 ns/iter 3.40896088676986 ns/iter 1.00
JSON_Object_Defines_Miss_Too_Large 3.717317136219251 ns/iter 3.7172158862195044 ns/iter 1.00
Pointer_Object_Traverse 53.10153571429055 ns/iter 52.17920000000049 ns/iter 1.02
Pointer_Object_Try_Traverse 65.0779196428581 ns/iter 65.36511607143731 ns/iter 1.00
Pointer_Push_Back_Pointer_To_Weak_Pointer 164.42619404640038 ns/iter 159.15837053570263 ns/iter 1.03
Schema_Frame_OMC_Full 520441499.99994713 ns/iter 464199199.9999391 ns/iter 1.12
Schema_Bundle_Meta_2020_12 23508164.285703156 ns/iter 23322826.66663256 ns/iter 1.01

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (linux/gcc)

Benchmark suite Current: 42a77f6 Previous: 7af0ac4 Ratio
Schema_Frame_OMC_Full 334989390.0000325 ns/iter 240679684.33333436 ns/iter 1.39
Schema_Bundle_Meta_2020_12 10630289.515151244 ns/iter 10623122.92424739 ns/iter 1.00
Pointer_Object_Traverse 49.66631780866654 ns/iter 45.28645619507305 ns/iter 1.10
Pointer_Object_Try_Traverse 23.356519868281516 ns/iter 22.986548137520522 ns/iter 1.02
Pointer_Push_Back_Pointer_To_Weak_Pointer 143.3993264627366 ns/iter 173.32253963464115 ns/iter 0.83
JSON_Array_Of_Objects_Unique 406.9225526131951 ns/iter 410.54436105942295 ns/iter 0.99
JSON_Parse_1 32957.35590825694 ns/iter 33176.24441922031 ns/iter 0.99
JSON_Fast_Hash_Helm_Chart_Lock 69.88093646628458 ns/iter 69.04826893050117 ns/iter 1.01
JSON_Equality_Helm_Chart_Lock 158.99066152304928 ns/iter 143.59601473579576 ns/iter 1.11
JSON_String_Equal/10 6.348290658411438 ns/iter 5.989953285405959 ns/iter 1.06
JSON_String_Equal/100 6.962236536846532 ns/iter 6.614038414932901 ns/iter 1.05
JSON_String_Equal_Small_By_Perfect_Hash/10 0.6307482422002155 ns/iter 0.9340950544691484 ns/iter 0.68
JSON_String_Equal_Small_By_Runtime_Perfect_Hash/10 11.619273545298748 ns/iter 11.806974933674395 ns/iter 0.98
JSON_String_Fast_Hash/10 1.2438205373177644 ns/iter 0.9345730942151321 ns/iter 1.33
JSON_String_Fast_Hash/100 1.2437134066871682 ns/iter 0.9328922194437421 ns/iter 1.33
JSON_String_Key_Hash/10 1.2472008995424813 ns/iter 1.2479190046031632 ns/iter 1.00
JSON_String_Key_Hash/100 0.9352363247260999 ns/iter 0.93372016666441 ns/iter 1.00
JSON_Object_Defines_Miss_Same_Length 2.800200915852797 ns/iter 2.4920212174593805 ns/iter 1.12
JSON_Object_Defines_Miss_Too_Small 2.4925132705502944 ns/iter 2.4866729258161806 ns/iter 1.00
JSON_Object_Defines_Miss_Too_Large 2.4864428374375076 ns/iter 2.4899397493590345 ns/iter 1.00
Regex_Lower_S_Or_Upper_S_Asterisk 3.4215102750093087 ns/iter 3.4210260650570987 ns/iter 1.00
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar 3.4232649056040847 ns/iter 3.4224455440626986 ns/iter 1.00
Regex_Period_Asterisk 3.4241321107355467 ns/iter 3.4248303265720117 ns/iter 1.00
Regex_Group_Period_Asterisk_Group 3.4231871283403588 ns/iter 3.4213873386906295 ns/iter 1.00
Regex_Period_Plus 3.7295701115031403 ns/iter 3.7329149573784446 ns/iter 1.00
Regex_Period 3.7295449438395423 ns/iter 3.7299718741075245 ns/iter 1.00
Regex_Caret_Period_Plus_Dollar 3.727724103601758 ns/iter 3.7312243684838573 ns/iter 1.00
Regex_Caret_Group_Period_Plus_Group_Dollar 3.74007624660593 ns/iter 3.7398985575376416 ns/iter 1.00
Regex_Caret_Period_Asterisk_Dollar 3.8984416710809007 ns/iter 3.4233984489891376 ns/iter 1.14
Regex_Caret_Group_Period_Asterisk_Group_Dollar 3.4228947677853383 ns/iter 3.4198937717834657 ns/iter 1.00
Regex_Caret_X_Hyphen 13.679243495987782 ns/iter 9.014959795690537 ns/iter 1.52
Regex_Period_Md_Dollar 89.59700688888964 ns/iter 88.17915928946589 ns/iter 1.02
Regex_Caret_Slash_Period_Asterisk 8.711659929503925 ns/iter 8.708182208058794 ns/iter 1.00
Regex_Caret_Period_Range_Dollar 3.4179888768390057 ns/iter 3.7418588819287253 ns/iter 0.91
Regex_Nested_Backtrack 820.2884645525986 ns/iter 819.4519537644977 ns/iter 1.00

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (macos/gcc)

Benchmark suite Current: 42a77f6 Previous: 7af0ac4 Ratio
Regex_Lower_S_Or_Upper_S_Asterisk 1.9865127709578532 ns/iter 1.9346772690899123 ns/iter 1.03
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar 2.020224893559476 ns/iter 1.9046923476322144 ns/iter 1.06
Regex_Period_Asterisk 1.9978376071240598 ns/iter 2.0016629037791143 ns/iter 1.00
Regex_Group_Period_Asterisk_Group 2.003608237087278 ns/iter 1.9209064056532066 ns/iter 1.04
Regex_Period_Plus 1.5914384408583035 ns/iter 1.6583020051481 ns/iter 0.96
Regex_Period 1.5982443427849184 ns/iter 1.6565295018078283 ns/iter 0.96
Regex_Caret_Period_Plus_Dollar 1.7542342201800958 ns/iter 1.676058008504846 ns/iter 1.05
Regex_Caret_Group_Period_Plus_Group_Dollar 1.683203476204092 ns/iter 1.5866082202121052 ns/iter 1.06
Regex_Caret_Period_Asterisk_Dollar 1.9061048959686977 ns/iter 1.9009305920252084 ns/iter 1.00
Regex_Caret_Group_Period_Asterisk_Group_Dollar 1.9639265896494544 ns/iter 1.9192111570828996 ns/iter 1.02
Regex_Caret_X_Hyphen 6.021263070032924 ns/iter 6.022312069412027 ns/iter 1.00
Regex_Period_Md_Dollar 69.3664505613708 ns/iter 70.08754707069852 ns/iter 0.99
Regex_Caret_Slash_Period_Asterisk 4.448938007603165 ns/iter 4.424094512384408 ns/iter 1.01
Regex_Caret_Period_Range_Dollar 1.9192537842291957 ns/iter 1.9027646810649306 ns/iter 1.01
Regex_Nested_Backtrack 856.2369741657766 ns/iter 850.791039599947 ns/iter 1.01
JSON_Array_Of_Objects_Unique 214.8198529086411 ns/iter 207.03543391655938 ns/iter 1.04
JSON_Parse_1 23045.917491035794 ns/iter 23332.054707457155 ns/iter 0.99
JSON_Fast_Hash_Helm_Chart_Lock 24.154498716066517 ns/iter 23.597014795180606 ns/iter 1.02
JSON_Equality_Helm_Chart_Lock 130.52720329085304 ns/iter 118.37983650669568 ns/iter 1.10
JSON_String_Equal/10 6.369119409242874 ns/iter 5.442661587223855 ns/iter 1.17
JSON_String_Equal/100 5.7187107512860385 ns/iter 5.139269324228634 ns/iter 1.11
JSON_String_Equal_Small_By_Perfect_Hash/10 0.852687017406875 ns/iter 0.7615608611183629 ns/iter 1.12
JSON_String_Equal_Small_By_Runtime_Perfect_Hash/10 3.91392365790981 ns/iter 3.5640654461269965 ns/iter 1.10
JSON_String_Fast_Hash/10 2.2062674534187896 ns/iter 1.9379888918472217 ns/iter 1.14
JSON_String_Fast_Hash/100 2.1032081967996694 ns/iter 1.922055428009397 ns/iter 1.09
JSON_String_Key_Hash/10 1.5503833515591057 ns/iter 1.4708244812427262 ns/iter 1.05
JSON_String_Key_Hash/100 2.0079266715646322 ns/iter 1.9687185459435372 ns/iter 1.02
JSON_Object_Defines_Miss_Same_Length 1.8311993547509835 ns/iter 1.769147541907026 ns/iter 1.04
JSON_Object_Defines_Miss_Too_Small 1.9306706722935953 ns/iter 1.9269776980531503 ns/iter 1.00
JSON_Object_Defines_Miss_Too_Large 1.772002634280857 ns/iter 1.752267024411095 ns/iter 1.01
Pointer_Object_Traverse 55.96934848779304 ns/iter 53.31035837995276 ns/iter 1.05
Pointer_Object_Try_Traverse 35.6606451531789 ns/iter 37.56519888455552 ns/iter 0.95
Pointer_Push_Back_Pointer_To_Weak_Pointer 162.14799768435853 ns/iter 158.01008409384514 ns/iter 1.03
Schema_Frame_OMC_Full 237146298.09061685 ns/iter 191110491.7526245 ns/iter 1.24
Schema_Bundle_Meta_2020_12 9104394.912719727 ns/iter 8689287.232189644 ns/iter 1.05

This comment was automatically generated by workflow using github-action-benchmark.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant