Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix instance locations framing calculations #1537

Merged
merged 1 commit into from
Feb 8, 2025
Merged

Conversation

jviotti
Copy link
Member

@jviotti jviotti commented Feb 8, 2025

Signed-off-by: Juan Cruz Viotti [email protected]

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (linux/llvm)

Benchmark suite Current: 3e9e307 Previous: 57fcc3c Ratio
Regex_Lower_S_Or_Upper_S_Asterisk 2.2056770105951045 ns/iter 2.21324512511772 ns/iter 1.00
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar 2.2376237409651605 ns/iter 2.2251830571098585 ns/iter 1.01
Regex_Period_Asterisk 2.2061411047569917 ns/iter 2.1996595834021435 ns/iter 1.00
Regex_Group_Period_Asterisk_Group 2.2129305033668456 ns/iter 2.195957790150231 ns/iter 1.01
Regex_Period_Plus 2.67433591225242 ns/iter 2.7959413464432514 ns/iter 0.96
Regex_Period 2.489417292609496 ns/iter 2.7976534236115342 ns/iter 0.89
Regex_Caret_Period_Plus_Dollar 2.4870375817411596 ns/iter 2.797634207908262 ns/iter 0.89
Regex_Caret_Group_Period_Plus_Group_Dollar 2.4966652388080894 ns/iter 2.8039844625621555 ns/iter 0.89
Regex_Caret_Period_Asterisk_Dollar 2.486753251831395 ns/iter 3.434365872892736 ns/iter 0.72
Regex_Caret_Group_Period_Asterisk_Group_Dollar 2.486509766746739 ns/iter 3.4169790603660637 ns/iter 0.73
Regex_Caret_X_Hyphen 12.574692426999672 ns/iter 13.07299164923992 ns/iter 0.96
Regex_Period_Md_Dollar 80.85826227352996 ns/iter 82.51872464857378 ns/iter 0.98
Regex_Caret_Slash_Period_Asterisk 5.904835634464098 ns/iter 5.905009555708624 ns/iter 1.00
Regex_Caret_Period_Range_Dollar 4.039382821396194 ns/iter 4.040613152934997 ns/iter 1.00
Regex_Nested_Backtrack 503.0132470000126 ns/iter 505.45061869816806 ns/iter 1.00
JSON_Array_Of_Objects_Unique 404.92137322017953 ns/iter 403.6923991963758 ns/iter 1.00
JSON_Parse_1 30826.038485140103 ns/iter 30596.335602094856 ns/iter 1.01
JSON_Fast_Hash_Helm_Chart_Lock 59.38084510543035 ns/iter 59.36953047485912 ns/iter 1.00
JSON_Equality_Helm_Chart_Lock 151.12472361778222 ns/iter 153.47666621524831 ns/iter 0.98
JSON_String_Equal/10 6.239735103879111 ns/iter 6.224609503583112 ns/iter 1.00
JSON_String_Equal/100 7.1047618199298315 ns/iter 6.845588029948627 ns/iter 1.04
JSON_String_Equal_Small_By_Perfect_Hash/10 0.9346979071648389 ns/iter 0.9356475160468047 ns/iter 1.00
JSON_String_Equal_Small_By_Runtime_Perfect_Hash/10 14.601576371482864 ns/iter 10.260302845318373 ns/iter 1.42
JSON_String_Fast_Hash/10 2.4887026664209064 ns/iter 2.488111621706666 ns/iter 1.00
JSON_String_Fast_Hash/100 2.4865859370192327 ns/iter 2.4877731448465417 ns/iter 1.00
JSON_String_Key_Hash/10 2.692741686000047 ns/iter 2.1786228836056485 ns/iter 1.24
JSON_String_Key_Hash/100 1.8677684635625351 ns/iter 1.9220461890875142 ns/iter 0.97
JSON_Object_Defines_Miss_Same_Length 3.7357429874027046 ns/iter 3.733847649333964 ns/iter 1.00
JSON_Object_Defines_Miss_Too_Small 3.743087900151405 ns/iter 3.7342949170925452 ns/iter 1.00
JSON_Object_Defines_Miss_Too_Large 3.7391420399429234 ns/iter 3.737895489695806 ns/iter 1.00
Pointer_Object_Traverse 45.038132931157065 ns/iter 44.26496525805417 ns/iter 1.02
Pointer_Object_Try_Traverse 52.425581282520426 ns/iter 52.38939811563776 ns/iter 1.00
Pointer_Push_Back_Pointer_To_Weak_Pointer 307.4784322065316 ns/iter 289.59946127889015 ns/iter 1.06

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (macos/llvm)

Benchmark suite Current: 3e9e307 Previous: 57fcc3c Ratio
Regex_Lower_S_Or_Upper_S_Asterisk 1.7004571976397769 ns/iter 1.9583521831521484 ns/iter 0.87
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar 1.7429513405881727 ns/iter 1.830709124421011 ns/iter 0.95
Regex_Period_Asterisk 1.6079470147746335 ns/iter 1.705627107657228 ns/iter 0.94
Regex_Group_Period_Asterisk_Group 1.6289028385270417 ns/iter 1.7388175106915464 ns/iter 0.94
Regex_Period_Plus 1.936606987309946 ns/iter 2.0318569340841277 ns/iter 0.95
Regex_Period 1.9863663627643053 ns/iter 2.0425598744843154 ns/iter 0.97
Regex_Caret_Period_Plus_Dollar 1.9240973051547503 ns/iter 2.021926284396524 ns/iter 0.95
Regex_Caret_Group_Period_Plus_Group_Dollar 2.1938486145289255 ns/iter 2.0144081425910807 ns/iter 1.09
Regex_Caret_Period_Asterisk_Dollar 1.815767239029617 ns/iter 1.6916195311815498 ns/iter 1.07
Regex_Caret_Group_Period_Asterisk_Group_Dollar 1.692961458218649 ns/iter 1.7093379850139825 ns/iter 0.99
Regex_Caret_X_Hyphen 6.739508238709958 ns/iter 7.117970028557164 ns/iter 0.95
Regex_Period_Md_Dollar 69.57498787165603 ns/iter 73.24459238882905 ns/iter 0.95
Regex_Caret_Slash_Period_Asterisk 5.2204547659572205 ns/iter 5.722917550721413 ns/iter 0.91
Regex_Caret_Period_Range_Dollar 2.2491725577452906 ns/iter 2.42459367704766 ns/iter 0.93
Regex_Nested_Backtrack 731.1635172675738 ns/iter 800.5740766964577 ns/iter 0.91
JSON_Array_Of_Objects_Unique 330.74311691964516 ns/iter 358.2890336749976 ns/iter 0.92
JSON_Parse_1 21559.034291622473 ns/iter 22794.1444949651 ns/iter 0.95
JSON_Fast_Hash_Helm_Chart_Lock 49.997535942893464 ns/iter 51.22781438829177 ns/iter 0.98
JSON_Equality_Helm_Chart_Lock 119.91885774119501 ns/iter 130.49880672428787 ns/iter 0.92
JSON_String_Equal/10 7.723937922812859 ns/iter 7.890035875344331 ns/iter 0.98
JSON_String_Equal/100 6.080089355996397 ns/iter 6.299543646788227 ns/iter 0.97
JSON_String_Equal_Small_By_Perfect_Hash/10 0.31931964848905975 ns/iter 0.3368126942643862 ns/iter 0.95
JSON_String_Equal_Small_By_Runtime_Perfect_Hash/10 3.361269736888107 ns/iter 3.3066860352590774 ns/iter 1.02
JSON_String_Fast_Hash/10 1.6009983473056528 ns/iter 1.8412583212084255 ns/iter 0.87
JSON_String_Fast_Hash/100 1.9589210657393277 ns/iter 2.0412385797790193 ns/iter 0.96
JSON_String_Key_Hash/10 1.2897041064056465 ns/iter 1.3514294298336818 ns/iter 0.95
JSON_String_Key_Hash/100 1.2958056018837047 ns/iter 1.3249724235507416 ns/iter 0.98
JSON_Object_Defines_Miss_Same_Length 2.2481583104514535 ns/iter 2.3231596721552847 ns/iter 0.97
JSON_Object_Defines_Miss_Too_Small 2.320623303570519 ns/iter 2.3893554429878274 ns/iter 0.97
JSON_Object_Defines_Miss_Too_Large 2.2526073567271694 ns/iter 2.380200270161164 ns/iter 0.95
Pointer_Object_Traverse 18.144109030076336 ns/iter 18.234154126765166 ns/iter 1.00
Pointer_Object_Try_Traverse 23.5469707789898 ns/iter 24.206661773253096 ns/iter 0.97
Pointer_Push_Back_Pointer_To_Weak_Pointer 184.29427781463679 ns/iter 184.4533184468813 ns/iter 1.00

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (windows/msvc)

Benchmark suite Current: 3e9e307 Previous: 57fcc3c Ratio
Regex_Lower_S_Or_Upper_S_Asterisk 6.8670312499996555 ns/iter 6.833373883929588 ns/iter 1.00
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar 7.187124999999485 ns/iter 6.853975446429977 ns/iter 1.05
Regex_Period_Asterisk 7.185005580357792 ns/iter 6.8539308035704085 ns/iter 1.05
Regex_Group_Period_Asterisk_Group 6.858835937499919 ns/iter 7.0714321428572 ns/iter 0.97
Regex_Period_Plus 7.383617187500643 ns/iter 7.429651306119565 ns/iter 0.99
Regex_Period 7.151848214285954 ns/iter 7.272991071428489 ns/iter 0.98
Regex_Caret_Period_Plus_Dollar 7.434960937498911 ns/iter 7.231762276784792 ns/iter 1.03
Regex_Caret_Group_Period_Plus_Group_Dollar 7.156954241072101 ns/iter 7.331421874999324 ns/iter 0.98
Regex_Caret_Period_Asterisk_Dollar 6.861609374999895 ns/iter 6.9932669642846745 ns/iter 0.98
Regex_Caret_Group_Period_Asterisk_Group_Dollar 6.976915178569243 ns/iter 7.133985236007083 ns/iter 0.98
Regex_Caret_X_Hyphen 14.250851052451752 ns/iter 14.259183035717019 ns/iter 1.00
Regex_Period_Md_Dollar 150.2480624889053 ns/iter 150.47093301469658 ns/iter 1.00
Regex_Caret_Slash_Period_Asterisk 10.313187499999543 ns/iter 10.518417187501683 ns/iter 0.98
Regex_Caret_Period_Range_Dollar 7.720237465536364 ns/iter 7.768389508928664 ns/iter 0.99
Regex_Nested_Backtrack 608.154732142907 ns/iter 608.0383035712852 ns/iter 1.00
JSON_Array_Of_Objects_Unique 498.64956222875185 ns/iter 488.5185802827047 ns/iter 1.02
JSON_Parse_1 80044.04017858085 ns/iter 81223.21428573848 ns/iter 0.99
JSON_Fast_Hash_Helm_Chart_Lock 64.27287500000847 ns/iter 67.10326999998415 ns/iter 0.96
JSON_Equality_Helm_Chart_Lock 187.5098738848462 ns/iter 186.25330234407423 ns/iter 1.01
JSON_String_Equal/10 8.983892370607675 ns/iter 8.992549107144246 ns/iter 1.00
JSON_String_Equal/100 9.927612009251671 ns/iter 9.937556205634342 ns/iter 1.00
JSON_String_Equal_Small_By_Perfect_Hash/10 2.1784478124999396 ns/iter 2.168285625000266 ns/iter 1.00
JSON_String_Equal_Small_By_Runtime_Perfect_Hash/10 14.838790112327374 ns/iter 14.814677132938408 ns/iter 1.00
JSON_String_Fast_Hash/10 4.034988757205914 ns/iter 4.0800926339290555 ns/iter 0.99
JSON_String_Fast_Hash/100 4.027460937499378 ns/iter 4.028599025051284 ns/iter 1.00
JSON_String_Key_Hash/10 7.791101562499847 ns/iter 7.920802455357392 ns/iter 0.98
JSON_String_Key_Hash/100 4.02475009647188 ns/iter 4.026559650047645 ns/iter 1.00
JSON_Object_Defines_Miss_Same_Length 3.7199051719295073 ns/iter 3.7157105290788732 ns/iter 1.00
JSON_Object_Defines_Miss_Too_Small 4.961289000000306 ns/iter 4.965528795751675 ns/iter 1.00
JSON_Object_Defines_Miss_Too_Large 3.4063768689174907 ns/iter 3.4073329740734013 ns/iter 1.00
Pointer_Object_Traverse 49.00927999999567 ns/iter 48.80525999999463 ns/iter 1.00
Pointer_Object_Try_Traverse 67.60426339287307 ns/iter 67.57286830357653 ns/iter 1.00
Pointer_Push_Back_Pointer_To_Weak_Pointer 166.55305803569473 ns/iter 160.16683661831414 ns/iter 1.04

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (macos/gcc)

Benchmark suite Current: 3e9e307 Previous: 57fcc3c Ratio
Regex_Lower_S_Or_Upper_S_Asterisk 2.023827817778193 ns/iter 1.8825880041351961 ns/iter 1.08
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar 2.046638259212678 ns/iter 1.8791688169100427 ns/iter 1.09
Regex_Period_Asterisk 2.0503571691624054 ns/iter 1.8800244099838497 ns/iter 1.09
Regex_Group_Period_Asterisk_Group 2.0614034107516717 ns/iter 1.8814021322990038 ns/iter 1.10
Regex_Period_Plus 1.7032419969782766 ns/iter 1.5673359340626543 ns/iter 1.09
Regex_Period 1.7365215659206423 ns/iter 1.5689924643498037 ns/iter 1.11
Regex_Caret_Period_Plus_Dollar 1.6975692050375577 ns/iter 1.5708249071566387 ns/iter 1.08
Regex_Caret_Group_Period_Plus_Group_Dollar 1.7215195653763036 ns/iter 1.5727256430746848 ns/iter 1.09
Regex_Caret_Period_Asterisk_Dollar 2.0934203027369445 ns/iter 1.8984326850382653 ns/iter 1.10
Regex_Caret_Group_Period_Asterisk_Group_Dollar 2.0599775687262674 ns/iter 1.881541592780166 ns/iter 1.09
Regex_Caret_X_Hyphen 6.535517572450359 ns/iter 6.126027284935777 ns/iter 1.07
Regex_Period_Md_Dollar 77.90519669350358 ns/iter 68.04899674887409 ns/iter 1.14
Regex_Caret_Slash_Period_Asterisk 4.9339698887595524 ns/iter 4.401628243309832 ns/iter 1.12
Regex_Caret_Period_Range_Dollar 1.9874943839425605 ns/iter 1.8825292383059935 ns/iter 1.06
Regex_Nested_Backtrack 925.2324779844819 ns/iter 820.9803815524178 ns/iter 1.13
JSON_Array_Of_Objects_Unique 225.3336403897296 ns/iter 210.5165797936312 ns/iter 1.07
JSON_Parse_1 25842.104241321595 ns/iter 22922.03221298376 ns/iter 1.13
JSON_Fast_Hash_Helm_Chart_Lock 25.872451094509472 ns/iter 23.766888111230237 ns/iter 1.09
JSON_Equality_Helm_Chart_Lock 127.83309073121767 ns/iter 115.29711452462577 ns/iter 1.11
JSON_String_Equal/10 5.676906269190111 ns/iter 5.424336860497339 ns/iter 1.05
JSON_String_Equal/100 5.6272507624567 ns/iter 5.1069767830157495 ns/iter 1.10
JSON_String_Equal_Small_By_Perfect_Hash/10 0.7916291718244549 ns/iter 0.7453677549612214 ns/iter 1.06
JSON_String_Equal_Small_By_Runtime_Perfect_Hash/10 3.91611500944002 ns/iter 3.5093959020381402 ns/iter 1.12
JSON_String_Fast_Hash/10 2.035299874447441 ns/iter 1.9267548735634323 ns/iter 1.06
JSON_String_Fast_Hash/100 2.050238256437115 ns/iter 1.9098343199353254 ns/iter 1.07
JSON_String_Key_Hash/10 1.5175676218624836 ns/iter 1.4459711549364933 ns/iter 1.05
JSON_String_Key_Hash/100 2.0596696376040513 ns/iter 1.9573203433725286 ns/iter 1.05
JSON_Object_Defines_Miss_Same_Length 1.8399409928228032 ns/iter 1.742340504214379 ns/iter 1.06
JSON_Object_Defines_Miss_Too_Small 2.0037253932096855 ns/iter 1.9021659557584234 ns/iter 1.05
JSON_Object_Defines_Miss_Too_Large 1.8900392472794552 ns/iter 1.7245856715080061 ns/iter 1.10
Pointer_Object_Traverse 56.59923542290778 ns/iter 52.280223216798596 ns/iter 1.08
Pointer_Object_Try_Traverse 39.56122311599956 ns/iter 35.934347639679565 ns/iter 1.10
Pointer_Push_Back_Pointer_To_Weak_Pointer 163.61816213452582 ns/iter 157.9992440769337 ns/iter 1.04

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (linux/gcc)

Benchmark suite Current: 3e9e307 Previous: 57fcc3c Ratio
Pointer_Object_Traverse 45.833952179327646 ns/iter 49.256180970175286 ns/iter 0.93
Pointer_Object_Try_Traverse 26.159137871137986 ns/iter 26.125727781465667 ns/iter 1.00
Pointer_Push_Back_Pointer_To_Weak_Pointer 144.78810458609428 ns/iter 145.1145543983442 ns/iter 1.00
JSON_Array_Of_Objects_Unique 411.2560659483046 ns/iter 408.92338069490216 ns/iter 1.01
JSON_Parse_1 33261.58376814535 ns/iter 33007.03525959448 ns/iter 1.01
JSON_Fast_Hash_Helm_Chart_Lock 62.54517966355007 ns/iter 62.741296493475176 ns/iter 1.00
JSON_Equality_Helm_Chart_Lock 150.24794839546215 ns/iter 149.33441798723186 ns/iter 1.01
JSON_String_Equal/10 6.3437401772447854 ns/iter 6.34210158483025 ns/iter 1.00
JSON_String_Equal/100 6.965080183496545 ns/iter 6.958076050521689 ns/iter 1.00
JSON_String_Equal_Small_By_Perfect_Hash/10 0.9345671659370712 ns/iter 0.933705074484109 ns/iter 1.00
JSON_String_Equal_Small_By_Runtime_Perfect_Hash/10 14.286363255440909 ns/iter 14.28846835274366 ns/iter 1.00
JSON_String_Fast_Hash/10 0.9319068185354372 ns/iter 0.9341127683816727 ns/iter 1.00
JSON_String_Fast_Hash/100 0.9324657715899235 ns/iter 0.9331731049130984 ns/iter 1.00
JSON_String_Key_Hash/10 1.673283810842783 ns/iter 1.6717016793052244 ns/iter 1.00
JSON_String_Key_Hash/100 1.9829372075694178 ns/iter 1.9833137786276849 ns/iter 1.00
JSON_Object_Defines_Miss_Same_Length 2.490227226561225 ns/iter 2.4859760607554455 ns/iter 1.00
JSON_Object_Defines_Miss_Too_Small 2.4870254449936056 ns/iter 2.4870298331266616 ns/iter 1.00
JSON_Object_Defines_Miss_Too_Large 3.109235018474438 ns/iter 3.1075878883694825 ns/iter 1.00
Regex_Lower_S_Or_Upper_S_Asterisk 3.42335550592551 ns/iter 3.422624259221597 ns/iter 1.00
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar 3.4207262129869314 ns/iter 3.4227808760443073 ns/iter 1.00
Regex_Period_Asterisk 3.428928046297577 ns/iter 3.421785562744786 ns/iter 1.00
Regex_Group_Period_Asterisk_Group 3.422276533262259 ns/iter 3.4222175776811334 ns/iter 1.00
Regex_Period_Plus 3.7457571922999087 ns/iter 3.730066459655144 ns/iter 1.00
Regex_Period 3.7436271752467407 ns/iter 3.7338566738512338 ns/iter 1.00
Regex_Caret_Period_Plus_Dollar 3.731904689492395 ns/iter 3.7319398350148667 ns/iter 1.00
Regex_Caret_Group_Period_Plus_Group_Dollar 3.7277872143518516 ns/iter 3.730839562146845 ns/iter 1.00
Regex_Caret_Period_Asterisk_Dollar 4.67162504414997 ns/iter 4.660697710071137 ns/iter 1.00
Regex_Caret_Group_Period_Asterisk_Group_Dollar 4.66081146594399 ns/iter 4.66204628334616 ns/iter 1.00
Regex_Caret_X_Hyphen 12.437624936806374 ns/iter 13.196786071260854 ns/iter 0.94
Regex_Period_Md_Dollar 92.75836868915249 ns/iter 92.53485078169291 ns/iter 1.00
Regex_Caret_Slash_Period_Asterisk 8.07907770743095 ns/iter 8.080343319211822 ns/iter 1.00
Regex_Caret_Period_Range_Dollar 4.6596334711302685 ns/iter 4.659931802504431 ns/iter 1.00
Regex_Nested_Backtrack 819.5184749079856 ns/iter 842.9729777126599 ns/iter 0.97

This comment was automatically generated by workflow using github-action-benchmark.

@jviotti jviotti changed the title [WIP] Fix instance locations framing calculations Fix instance locations framing calculations Feb 8, 2025
@jviotti jviotti marked this pull request as ready for review February 8, 2025 00:58
@jviotti jviotti merged commit a33e514 into main Feb 8, 2025
13 checks passed
@jviotti jviotti deleted the fix-instance-locations branch February 8, 2025 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant