Improve error when making a $ref to a non-schema
#1214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jviotti
force-pushed
the
ref-to-non-schema
branch
from
f9ae141 to
e01a3a4
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Benchmark (macos/llvm)
| Benchmark suite | Current: 8319a6c | Previous: 23ee0c8 | Ratio |
|---|---|---|---|
JSONSchema_Validate_Draft4_Meta_1_No_Callback |
660.8843793926294 ns/iter |
694.6673961078225 ns/iter |
0.95 |
JSONSchema_Validate_Draft4_Required_Properties |
784.7227487749279 ns/iter |
890.5208143264445 ns/iter |
0.88 |
JSONSchema_Validate_Draft4_Many_Optional_Properties_Minimal_Match |
142.14704110744734 ns/iter |
154.9996342330371 ns/iter |
0.92 |
JSONSchema_Validate_Draft4_Few_Optional_Properties_Minimal_Match |
104.29886391969718 ns/iter |
107.63533544464467 ns/iter |
0.97 |
JSONSchema_Validate_Draft4_Items_Schema |
1976.083380760259 ns/iter |
2112.1205854572636 ns/iter |
0.94 |
JSONSchema_Validate_Draft4_Nested_Object |
1217.1217186368742 ns/iter |
1291.1982147418419 ns/iter |
0.94 |
JSONSchema_Validate_Draft4_Properties_Triad_Optional |
1320.2474769783264 ns/iter |
1438.2914600986426 ns/iter |
0.92 |
JSONSchema_Validate_Draft4_Properties_Triad_Closed |
965.0209171148275 ns/iter |
1058.0773247938298 ns/iter |
0.91 |
JSONSchema_Validate_Draft4_Properties_Triad_Required |
1319.1560728146835 ns/iter |
1442.1622008864679 ns/iter |
0.91 |
JSONSchema_Validate_Draft4_Non_Recursive_Ref |
193.88223584449418 ns/iter |
191.64956978613205 ns/iter |
1.01 |
JSONSchema_Validate_Draft4_Pattern_Properties_True |
1308.036291678469 ns/iter |
1380.827346202137 ns/iter |
0.95 |
JSONSchema_Validate_Draft4_Ref_To_Single_Property |
118.31001578585766 ns/iter |
114.39457122803245 ns/iter |
1.03 |
JSONSchema_Validate_Draft4_Additional_Properties_Type |
371.12168667498185 ns/iter |
355.53428195892405 ns/iter |
1.04 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Benchmark (linux/llvm)
| Benchmark suite | Current: 8319a6c | Previous: 23ee0c8 | Ratio |
|---|---|---|---|
JSONSchema_Validate_Draft4_Meta_1_No_Callback |
17500.977349713638 ns/iter |
17483.282801788875 ns/iter |
1.00 |
JSONSchema_Validate_Draft4_Required_Properties |
7364.978117566114 ns/iter |
7195.048809720544 ns/iter |
1.02 |
JSONSchema_Validate_Draft4_Many_Optional_Properties_Minimal_Match |
1910.9265828621299 ns/iter |
1895.3667848804628 ns/iter |
1.01 |
JSONSchema_Validate_Draft4_Few_Optional_Properties_Minimal_Match |
903.0202435506318 ns/iter |
914.0628615885564 ns/iter |
0.99 |
JSONSchema_Validate_Draft4_Items_Schema |
124438.42347301367 ns/iter |
124998.01222754786 ns/iter |
1.00 |
JSONSchema_Validate_Draft4_Nested_Object |
55839.83145348785 ns/iter |
56330.434278857196 ns/iter |
0.99 |
JSONSchema_Validate_Draft4_Properties_Triad_Optional |
9048.541009055782 ns/iter |
9155.152472527303 ns/iter |
0.99 |
JSONSchema_Validate_Draft4_Properties_Triad_Closed |
8498.765641274542 ns/iter |
8585.703742796806 ns/iter |
0.99 |
JSONSchema_Validate_Draft4_Properties_Triad_Required |
9240.447672356171 ns/iter |
9397.634789258145 ns/iter |
0.98 |
JSONSchema_Validate_Draft4_Non_Recursive_Ref |
2205.5494977982885 ns/iter |
2237.873632379703 ns/iter |
0.99 |
JSONSchema_Validate_Draft4_Pattern_Properties_True |
6593.828117446533 ns/iter |
6525.520940086395 ns/iter |
1.01 |
JSONSchema_Validate_Draft4_Ref_To_Single_Property |
901.2691933790927 ns/iter |
922.0790979757547 ns/iter |
0.98 |
JSONSchema_Validate_Draft4_Additional_Properties_Type |
2319.0048557242735 ns/iter |
2373.3122994832643 ns/iter |
0.98 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Benchmark (linux/gcc)
| Benchmark suite | Current: 8319a6c | Previous: 23ee0c8 | Ratio |
|---|---|---|---|
JSONSchema_Validate_Draft4_Meta_1_No_Callback |
1087.9535921073762 ns/iter |
1065.6927341507485 ns/iter |
1.02 |
JSONSchema_Validate_Draft4_Required_Properties |
2186.205872866021 ns/iter |
2213.5482720835466 ns/iter |
0.99 |
JSONSchema_Validate_Draft4_Many_Optional_Properties_Minimal_Match |
190.05504803792684 ns/iter |
189.7473042650364 ns/iter |
1.00 |
JSONSchema_Validate_Draft4_Few_Optional_Properties_Minimal_Match |
154.87520744913905 ns/iter |
162.1801057568127 ns/iter |
0.95 |
JSONSchema_Validate_Draft4_Items_Schema |
3617.9732345323887 ns/iter |
3631.2486955978106 ns/iter |
1.00 |
JSONSchema_Validate_Draft4_Nested_Object |
1747.4917177408036 ns/iter |
1751.2367485932516 ns/iter |
1.00 |
JSONSchema_Validate_Draft4_Properties_Triad_Optional |
1775.0224926225483 ns/iter |
1720.6624010972555 ns/iter |
1.03 |
JSONSchema_Validate_Draft4_Properties_Triad_Closed |
1449.9525589377322 ns/iter |
1407.5350087667568 ns/iter |
1.03 |
JSONSchema_Validate_Draft4_Properties_Triad_Required |
1856.2897827198408 ns/iter |
1801.291847665703 ns/iter |
1.03 |
JSONSchema_Validate_Draft4_Non_Recursive_Ref |
430.60654860178323 ns/iter |
437.65128083865466 ns/iter |
0.98 |
JSONSchema_Validate_Draft4_Pattern_Properties_True |
2387.9408585296082 ns/iter |
2369.2337482899075 ns/iter |
1.01 |
JSONSchema_Validate_Draft4_Ref_To_Single_Property |
165.82526566423968 ns/iter |
176.95924234654288 ns/iter |
0.94 |
JSONSchema_Validate_Draft4_Additional_Properties_Type |
1033.3630720454346 ns/iter |
1048.306034108336 ns/iter |
0.99 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Benchmark (windows/msvc)
| Benchmark suite | Current: 8319a6c | Previous: 23ee0c8 | Ratio |
|---|---|---|---|
JSONSchema_Validate_Draft4_Meta_1_No_Callback |
3039.290636967871 ns/iter |
3029.699858772314 ns/iter |
1.00 |
JSONSchema_Validate_Draft4_Required_Properties |
1658.7753177845652 ns/iter |
1638.6676339286462 ns/iter |
1.01 |
JSONSchema_Validate_Draft4_Many_Optional_Properties_Minimal_Match |
616.7855357143179 ns/iter |
608.3584821429408 ns/iter |
1.01 |
JSONSchema_Validate_Draft4_Few_Optional_Properties_Minimal_Match |
431.89368749999346 ns/iter |
430.5101855708911 ns/iter |
1.00 |
JSONSchema_Validate_Draft4_Items_Schema |
12060.201785713176 ns/iter |
12094.737499998993 ns/iter |
1.00 |
JSONSchema_Validate_Draft4_Nested_Object |
6819.283928571451 ns/iter |
6767.978571427793 ns/iter |
1.01 |
JSONSchema_Validate_Draft4_Properties_Triad_Optional |
5837.8973214284915 ns/iter |
5806.8455357138355 ns/iter |
1.01 |
JSONSchema_Validate_Draft4_Properties_Triad_Closed |
4826.571452296055 ns/iter |
4786.101192946576 ns/iter |
1.01 |
JSONSchema_Validate_Draft4_Properties_Triad_Required |
5846.372321428817 ns/iter |
5894.770535714348 ns/iter |
0.99 |
JSONSchema_Validate_Draft4_Non_Recursive_Ref |
692.1705357142267 ns/iter |
690.6915178570878 ns/iter |
1.00 |
JSONSchema_Validate_Draft4_Pattern_Properties_True |
8043.748883929273 ns/iter |
8104.43526785625 ns/iter |
0.99 |
JSONSchema_Validate_Draft4_Ref_To_Single_Property |
438.6374999999987 ns/iter |
428.1153213572947 ns/iter |
1.02 |
JSONSchema_Validate_Draft4_Additional_Properties_Type |
973.4639404178594 ns/iter |
960.373767690115 ns/iter |
1.01 |
This comment was automatically generated by workflow using github-action-benchmark.
Signed-off-by: Juan Cruz Viotti <[email protected]>
jviotti
force-pushed
the
ref-to-non-schema
branch
from
e01a3a4 to
8319a6c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Juan Cruz Viotti [email protected]