Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce a new LoopPropertiesType(Strict) compiler step #1213

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

jviotti
Copy link
Member

@jviotti jviotti commented Sep 23, 2024

Signed-off-by: Juan Cruz Viotti [email protected]

@jviotti jviotti force-pushed the loop-properties-type branch from 6e0d0e6 to 8b3bdc8 Compare September 23, 2024 18:52
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (macos/llvm)

Benchmark suite Current: 536d5b0 Previous: a4c71c9 Ratio
JSONSchema_Validate_Draft4_Meta_1_No_Callback 696.9017439601656 ns/iter 768.4116964639468 ns/iter 0.91
JSONSchema_Validate_Draft4_Required_Properties 873.2871078601082 ns/iter 866.8196412718464 ns/iter 1.01
JSONSchema_Validate_Draft4_Many_Optional_Properties_Minimal_Match 145.48887987135075 ns/iter 161.40662346142722 ns/iter 0.90
JSONSchema_Validate_Draft4_Few_Optional_Properties_Minimal_Match 114.2736867725026 ns/iter 118.63357530622011 ns/iter 0.96
JSONSchema_Validate_Draft4_Items_Schema 2228.914514857503 ns/iter 2077.242749154637 ns/iter 1.07
JSONSchema_Validate_Draft4_Nested_Object 1372.0803560304646 ns/iter 1255.98986252347 ns/iter 1.09
JSONSchema_Validate_Draft4_Properties_Triad_Optional 1394.5431896992998 ns/iter 1479.2016603238326 ns/iter 0.94
JSONSchema_Validate_Draft4_Properties_Triad_Closed 1071.8385429432692 ns/iter 1097.561957213763 ns/iter 0.98
JSONSchema_Validate_Draft4_Properties_Triad_Required 1423.3442493095665 ns/iter 1439.5353453052364 ns/iter 0.99
JSONSchema_Validate_Draft4_Non_Recursive_Ref 191.04602803934372 ns/iter 519.2743880338112 ns/iter 0.37
JSONSchema_Validate_Draft4_Pattern_Properties_True 1363.170972965615 ns/iter 1413.7547404034117 ns/iter 0.96
JSONSchema_Validate_Draft4_Ref_To_Single_Property 114.72757389654244 ns/iter 119.14885291696025 ns/iter 0.96
JSONSchema_Validate_Draft4_Additional_Properties_Type 346.06516921548325 ns/iter 715.1348749293031 ns/iter 0.48

This comment was automatically generated by workflow using github-action-benchmark.

@jviotti jviotti force-pushed the loop-properties-type branch from 8b3bdc8 to 7ef0642 Compare September 23, 2024 19:00
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (windows/msvc)

Benchmark suite Current: 536d5b0 Previous: a4c71c9 Ratio
JSONSchema_Validate_Draft4_Meta_1_No_Callback 2991.367705872718 ns/iter 2933.6355809640017 ns/iter 1.02
JSONSchema_Validate_Draft4_Required_Properties 1619.1394961119272 ns/iter 1634.0462053570093 ns/iter 0.99
JSONSchema_Validate_Draft4_Many_Optional_Properties_Minimal_Match 614.7174999999346 ns/iter 623.4852678572013 ns/iter 0.99
JSONSchema_Validate_Draft4_Few_Optional_Properties_Minimal_Match 418.2193979360808 ns/iter 443.61294590729307 ns/iter 0.94
JSONSchema_Validate_Draft4_Items_Schema 12011.3124999993 ns/iter 11493.320312499833 ns/iter 1.05
JSONSchema_Validate_Draft4_Nested_Object 6808.085714286198 ns/iter 6699.348214287478 ns/iter 1.02
JSONSchema_Validate_Draft4_Properties_Triad_Optional 5812.518999999837 ns/iter 5785.50357142912 ns/iter 1.00
JSONSchema_Validate_Draft4_Properties_Triad_Closed 4776.581139805207 ns/iter 4807.117550997643 ns/iter 0.99
JSONSchema_Validate_Draft4_Properties_Triad_Required 5891.017000000146 ns/iter 5859.0223214289545 ns/iter 1.01
JSONSchema_Validate_Draft4_Non_Recursive_Ref 674.816339285757 ns/iter 1215.5746428573723 ns/iter 0.56
JSONSchema_Validate_Draft4_Pattern_Properties_True 8095.3392857135195 ns/iter 8162.9497767846515 ns/iter 0.99
JSONSchema_Validate_Draft4_Ref_To_Single_Property 428.90856249996995 ns/iter 449.8988236877546 ns/iter 0.95
JSONSchema_Validate_Draft4_Additional_Properties_Type 962.8002844640466 ns/iter 1619.5848975993179 ns/iter 0.59

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (linux/llvm)

Benchmark suite Current: 536d5b0 Previous: a4c71c9 Ratio
JSONSchema_Validate_Draft4_Meta_1_No_Callback 17418.617803266552 ns/iter 17053.12537694987 ns/iter 1.02
JSONSchema_Validate_Draft4_Required_Properties 7161.314463556758 ns/iter 7162.285303154954 ns/iter 1.00
JSONSchema_Validate_Draft4_Many_Optional_Properties_Minimal_Match 1873.9569587663211 ns/iter 1848.608004231017 ns/iter 1.01
JSONSchema_Validate_Draft4_Few_Optional_Properties_Minimal_Match 911.7457851939956 ns/iter 892.6423514809288 ns/iter 1.02
JSONSchema_Validate_Draft4_Items_Schema 124633.95602260942 ns/iter 115070.04306141274 ns/iter 1.08
JSONSchema_Validate_Draft4_Nested_Object 56461.58807893729 ns/iter 53819.66158677206 ns/iter 1.05
JSONSchema_Validate_Draft4_Properties_Triad_Optional 9067.982854854003 ns/iter 8841.84646274041 ns/iter 1.03
JSONSchema_Validate_Draft4_Properties_Triad_Closed 8475.015239581708 ns/iter 8253.44892226762 ns/iter 1.03
JSONSchema_Validate_Draft4_Properties_Triad_Required 9247.237006594394 ns/iter 8976.59859551926 ns/iter 1.03
JSONSchema_Validate_Draft4_Non_Recursive_Ref 2222.1418412960265 ns/iter 4225.448252915678 ns/iter 0.53
JSONSchema_Validate_Draft4_Pattern_Properties_True 6422.260737741826 ns/iter 6273.220299647581 ns/iter 1.02
JSONSchema_Validate_Draft4_Ref_To_Single_Property 918.3792167913481 ns/iter 892.5204786849945 ns/iter 1.03
JSONSchema_Validate_Draft4_Additional_Properties_Type 2348.1798758577584 ns/iter 7110.603608817619 ns/iter 0.33

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (linux/gcc)

Benchmark suite Current: 536d5b0 Previous: a4c71c9 Ratio
JSONSchema_Validate_Draft4_Meta_1_No_Callback 1072.2875018370034 ns/iter 1051.5448399520749 ns/iter 1.02
JSONSchema_Validate_Draft4_Required_Properties 2204.021665365679 ns/iter 2181.3952227500613 ns/iter 1.01
JSONSchema_Validate_Draft4_Many_Optional_Properties_Minimal_Match 188.79329477832565 ns/iter 182.2082258966129 ns/iter 1.04
JSONSchema_Validate_Draft4_Few_Optional_Properties_Minimal_Match 159.21350993263204 ns/iter 154.25007169340134 ns/iter 1.03
JSONSchema_Validate_Draft4_Items_Schema 3623.923271574845 ns/iter 3579.207584481475 ns/iter 1.01
JSONSchema_Validate_Draft4_Nested_Object 1757.2151331202465 ns/iter 1726.7254181536782 ns/iter 1.02
JSONSchema_Validate_Draft4_Properties_Triad_Optional 1724.8611055832998 ns/iter 1721.8313187799715 ns/iter 1.00
JSONSchema_Validate_Draft4_Properties_Triad_Closed 1417.629215372648 ns/iter 1391.3917847121959 ns/iter 1.02
JSONSchema_Validate_Draft4_Properties_Triad_Required 1804.6871533679177 ns/iter 1808.4795426216365 ns/iter 1.00
JSONSchema_Validate_Draft4_Non_Recursive_Ref 434.9731074277753 ns/iter 740.3379896080169 ns/iter 0.59
JSONSchema_Validate_Draft4_Pattern_Properties_True 2389.6610386690145 ns/iter 2385.6421335134182 ns/iter 1.00
JSONSchema_Validate_Draft4_Ref_To_Single_Property 172.4500916508506 ns/iter 163.68814235146954 ns/iter 1.05
JSONSchema_Validate_Draft4_Additional_Properties_Type 1056.027646919631 ns/iter 1418.1163998049128 ns/iter 0.74

This comment was automatically generated by workflow using github-action-benchmark.

@jviotti jviotti force-pushed the loop-properties-type branch from 7ef0642 to 536d5b0 Compare September 23, 2024 19:06
@jviotti jviotti marked this pull request as ready for review September 23, 2024 19:06
@jviotti jviotti merged commit 23ee0c8 into main Sep 23, 2024
13 checks passed
@jviotti jviotti deleted the loop-properties-type branch September 23, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant