Skip to content

Commit

Permalink
Don't post benchmark comments from forks (#1548)
Browse files Browse the repository at this point in the history 
Signed-off-by: Juan Cruz Viotti <[email protected]>
  • Loading branch information
@jviotti
jviotti authored Feb 11, 2025
1 parent a620175 commit b5cdffb
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion .github/workflows/ci.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,9 @@ jobs:
if: matrix.platform.benchmark

- uses: benchmark-action/github-action-benchmark@v1
if: matrix.platform.benchmark
# Avoid posting messages on forks until we figure out how to make it work
# See https://github.com/benchmark-action/github-action-benchmark/issues/279
if: matrix.platform.benchmark && github.event.pull_request.head.repo.fork == false
with:
name: Benchmark (${{ matrix.platform.benchmark }})
tool: googlecpp
Expand Down

5 comments on commit b5cdffb

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (linux/llvm)

Benchmark suite Current: b5cdffb Previous: a620175 Ratio
Regex_Lower_S_Or_Upper_S_Asterisk 2.2349538849972546 ns/iter 2.3167026728323528 ns/iter 0.96
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar 2.1942738388335385 ns/iter 2.3044702283670198 ns/iter 0.95
Regex_Period_Asterisk 2.184912592899142 ns/iter 2.311942946357336 ns/iter 0.95
Regex_Group_Period_Asterisk_Group 2.1917092653176926 ns/iter 2.3164350303353602 ns/iter 0.95
Regex_Period_Plus 2.490796317542416 ns/iter 2.520368470767164 ns/iter 0.99
Regex_Period 2.4871989478952465 ns/iter 2.517917832321795 ns/iter 0.99
Regex_Caret_Period_Plus_Dollar 2.491267001993584 ns/iter 2.521778422588157 ns/iter 0.99
Regex_Caret_Group_Period_Plus_Group_Dollar 2.487302898267284 ns/iter 2.521473358547691 ns/iter 0.99
Regex_Caret_Period_Asterisk_Dollar 3.106538363801349 ns/iter 3.4508573613413813 ns/iter 0.90
Regex_Caret_Group_Period_Asterisk_Group_Dollar 2.1801077423006796 ns/iter 3.4537486993140107 ns/iter 0.63
Regex_Caret_X_Hyphen 12.470036935261204 ns/iter 13.070158996221645 ns/iter 0.95
Regex_Period_Md_Dollar 73.30295523316838 ns/iter 75.53456033958885 ns/iter 0.97
Regex_Caret_Slash_Period_Asterisk 5.911520557436913 ns/iter 7.190909502204701 ns/iter 0.82
Regex_Caret_Period_Range_Dollar 2.5108495732630898 ns/iter 3.7518309355121624 ns/iter 0.67
Regex_Nested_Backtrack 496.679884812141 ns/iter 500.40121688966855 ns/iter 0.99
JSON_Array_Of_Objects_Unique 392.63670107594385 ns/iter 395.05215457266377 ns/iter 0.99
JSON_Parse_1 30490.11678264249 ns/iter 30535.84762773975 ns/iter 1.00
JSON_Fast_Hash_Helm_Chart_Lock 56.01237821565964 ns/iter 55.588912713233526 ns/iter 1.01
JSON_Equality_Helm_Chart_Lock 161.54335727558734 ns/iter 153.57698429478194 ns/iter 1.05
JSON_String_Equal/10 7.014440762903042 ns/iter 6.560053315541663 ns/iter 1.07
JSON_String_Equal/100 6.8515540511659525 ns/iter 7.170889023357301 ns/iter 0.96
JSON_String_Equal_Small_By_Perfect_Hash/10 0.9391825579963624 ns/iter 0.9403560781038774 ns/iter 1.00
JSON_String_Equal_Small_By_Runtime_Perfect_Hash/10 10.260861052693743 ns/iter 14.694651894672626 ns/iter 0.70
JSON_String_Fast_Hash/10 2.1768002459246993 ns/iter 2.185812581541609 ns/iter 1.00
JSON_String_Fast_Hash/100 2.176187345810927 ns/iter 2.1780205297854214 ns/iter 1.00
JSON_String_Key_Hash/10 2.491150479145749 ns/iter 2.6847264472344055 ns/iter 0.93
JSON_String_Key_Hash/100 2.179533000461269 ns/iter 2.2239328646772556 ns/iter 0.98
JSON_Object_Defines_Miss_Same_Length 3.7318839931830614 ns/iter 3.737731387657005 ns/iter 1.00
JSON_Object_Defines_Miss_Too_Small 3.73185613286778 ns/iter 3.7343996225603906 ns/iter 1.00
JSON_Object_Defines_Miss_Too_Large 3.7354132471788604 ns/iter 3.745720734285707 ns/iter 1.00
Pointer_Object_Traverse 44.96096012680536 ns/iter 46.41068900626387 ns/iter 0.97
Pointer_Object_Try_Traverse 52.30335672145912 ns/iter 55.205993503851204 ns/iter 0.95
Pointer_Push_Back_Pointer_To_Weak_Pointer 349.95490662113014 ns/iter 353.07503840512555 ns/iter 0.99
Schema_Frame_OMC_Full 241514758.33332372 ns/iter 242642051.33332932 ns/iter 1.00
Schema_Bundle_Meta_2020_12 10386397.253723567 ns/iter 10446305.970142579 ns/iter 0.99

This comment was automatically generated by workflow using github-action-benchmark.

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (macos/llvm)

Benchmark suite Current: b5cdffb Previous: a620175 Ratio
Regex_Lower_S_Or_Upper_S_Asterisk 1.8444213923781547 ns/iter 1.5916841811392546 ns/iter 1.16
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar 1.8183604934551092 ns/iter 1.579251436867043 ns/iter 1.15
Regex_Period_Asterisk 1.7942702796952148 ns/iter 1.57293276852572 ns/iter 1.14
Regex_Group_Period_Asterisk_Group 1.7961001637624718 ns/iter 1.5886349449704116 ns/iter 1.13
Regex_Period_Plus 2.1200654575678533 ns/iter 1.891979118398112 ns/iter 1.12
Regex_Period 2.1769124799194315 ns/iter 1.971832541458266 ns/iter 1.10
Regex_Caret_Period_Plus_Dollar 2.05146954692257 ns/iter 1.9233579541024965 ns/iter 1.07
Regex_Caret_Group_Period_Plus_Group_Dollar 2.072047340594785 ns/iter 1.8904365839353994 ns/iter 1.10
Regex_Caret_Period_Asterisk_Dollar 1.7205541920359066 ns/iter 1.5797839909386546 ns/iter 1.09
Regex_Caret_Group_Period_Asterisk_Group_Dollar 1.6753444860202664 ns/iter 1.578680186392724 ns/iter 1.06
Regex_Caret_X_Hyphen 7.421579655167888 ns/iter 6.949801479424407 ns/iter 1.07
Regex_Period_Md_Dollar 74.04714701995356 ns/iter 67.9253164423842 ns/iter 1.09
Regex_Caret_Slash_Period_Asterisk 5.746620726938812 ns/iter 5.045402408048544 ns/iter 1.14
Regex_Caret_Period_Range_Dollar 2.355355144535292 ns/iter 2.202695889448325 ns/iter 1.07
Regex_Nested_Backtrack 765.6018249025426 ns/iter 731.3505894960754 ns/iter 1.05
JSON_Array_Of_Objects_Unique 426.00059730069825 ns/iter 407.4019783980228 ns/iter 1.05
JSON_Parse_1 22370.080549534705 ns/iter 22119.71916971969 ns/iter 1.01
JSON_Fast_Hash_Helm_Chart_Lock 55.2421625000079 ns/iter 47.864043865274205 ns/iter 1.15
JSON_Equality_Helm_Chart_Lock 128.12546689342 ns/iter 118.82415820298301 ns/iter 1.08
JSON_String_Equal/10 7.847758956212208 ns/iter 8.199927989427573 ns/iter 0.96
JSON_String_Equal/100 6.346505843573472 ns/iter 6.079110690113043 ns/iter 1.04
JSON_String_Equal_Small_By_Perfect_Hash/10 0.3354873845267403 ns/iter 0.3142998326368521 ns/iter 1.07
JSON_String_Equal_Small_By_Runtime_Perfect_Hash/10 3.0269105104197616 ns/iter 2.929257172646389 ns/iter 1.03
JSON_String_Fast_Hash/10 1.6083211754770361 ns/iter 1.5689949799513878 ns/iter 1.03
JSON_String_Fast_Hash/100 1.9520491207902047 ns/iter 1.8855540903041088 ns/iter 1.04
JSON_String_Key_Hash/10 1.3576679287423095 ns/iter 1.2563855054006747 ns/iter 1.08
JSON_String_Key_Hash/100 1.3763617160442967 ns/iter 1.2568109487583037 ns/iter 1.10
JSON_Object_Defines_Miss_Same_Length 2.3100718052589 ns/iter 2.195334511562431 ns/iter 1.05
JSON_Object_Defines_Miss_Too_Small 2.302926452706485 ns/iter 2.2775906464982456 ns/iter 1.01
JSON_Object_Defines_Miss_Too_Large 2.310927124726863 ns/iter 2.1965170625325707 ns/iter 1.05
Pointer_Object_Traverse 16.104087297463778 ns/iter 15.36115610425304 ns/iter 1.05
Pointer_Object_Try_Traverse 22.460817472779482 ns/iter 21.783645873602453 ns/iter 1.03
Pointer_Push_Back_Pointer_To_Weak_Pointer 173.625981077812 ns/iter 176.19319705299154 ns/iter 0.99
Schema_Frame_OMC_Full 161518675.0000021 ns/iter 167216885.24998513 ns/iter 0.97
Schema_Bundle_Meta_2020_12 7383415.343743612 ns/iter 7675407.652168013 ns/iter 0.96

This comment was automatically generated by workflow using github-action-benchmark.

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (windows/msvc)

Benchmark suite Current: b5cdffb Previous: a620175 Ratio
Regex_Lower_S_Or_Upper_S_Asterisk 6.534661830358399 ns/iter 6.9683604910711745 ns/iter 0.94
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar 6.561756696429809 ns/iter 6.726704434255779 ns/iter 0.98
Regex_Period_Asterisk 6.705693749998837 ns/iter 6.603847098214694 ns/iter 1.02
Regex_Group_Period_Asterisk_Group 7.028895089286534 ns/iter 6.583189732141749 ns/iter 1.07
Regex_Period_Plus 7.002263392856938 ns/iter 7.061370535712541 ns/iter 0.99
Regex_Period 7.055739955355022 ns/iter 7.131059151784009 ns/iter 0.99
Regex_Caret_Period_Plus_Dollar 6.8786557728630395 ns/iter 6.894733258930229 ns/iter 1.00
Regex_Caret_Group_Period_Plus_Group_Dollar 7.048380580358631 ns/iter 6.900408035714837 ns/iter 1.02
Regex_Caret_Period_Asterisk_Dollar 6.8280696428563 ns/iter 6.6363325892839145 ns/iter 1.03
Regex_Caret_Group_Period_Asterisk_Group_Dollar 6.738003348214505 ns/iter 6.5248705357134895 ns/iter 1.03
Regex_Caret_X_Hyphen 14.42048660714639 ns/iter 11.951487500002855 ns/iter 1.21
Regex_Period_Md_Dollar 153.9481473214112 ns/iter 150.98736607142322 ns/iter 1.02
Regex_Caret_Slash_Period_Asterisk 10.284473437501163 ns/iter 10.20920468749864 ns/iter 1.01
Regex_Caret_Period_Range_Dollar 7.416595982141822 ns/iter 7.420445312499778 ns/iter 1.00
Regex_Nested_Backtrack 598.6018750001725 ns/iter 608.8270535715066 ns/iter 0.98
JSON_Array_Of_Objects_Unique 404.27340159490024 ns/iter 409.62464242739645 ns/iter 0.99
JSON_Parse_1 98320.45312499815 ns/iter 96796.15625000081 ns/iter 1.02
JSON_Fast_Hash_Helm_Chart_Lock 55.8829553571424 ns/iter 53.1475300000011 ns/iter 1.05
JSON_Equality_Helm_Chart_Lock 195.42917816333147 ns/iter 197.69096407957687 ns/iter 0.99
JSON_String_Equal/10 10.0505421874999 ns/iter 9.767365134967092 ns/iter 1.03
JSON_String_Equal/100 9.922209330706126 ns/iter 9.95611602697979 ns/iter 1.00
JSON_String_Equal_Small_By_Perfect_Hash/10 2.1672815625002784 ns/iter 2.1666440624997563 ns/iter 1.00
JSON_String_Equal_Small_By_Runtime_Perfect_Hash/10 14.52056249999905 ns/iter 14.63574999999955 ns/iter 0.99
JSON_String_Fast_Hash/10 3.0986915178569268 ns/iter 3.1514137549244707 ns/iter 0.98
JSON_String_Fast_Hash/100 3.0968401785713695 ns/iter 3.1454932086679577 ns/iter 0.98
JSON_String_Key_Hash/10 7.602110491072368 ns/iter 7.474392823775005 ns/iter 1.02
JSON_String_Key_Hash/100 3.721802494184263 ns/iter 3.7238362433500254 ns/iter 1.00
JSON_Object_Defines_Miss_Same_Length 4.033598221487906 ns/iter 4.028954203624034 ns/iter 1.00
JSON_Object_Defines_Miss_Too_Small 3.404046734992544 ns/iter 3.406188075035641 ns/iter 1.00
JSON_Object_Defines_Miss_Too_Large 3.7241571362065766 ns/iter 3.7178110647894034 ns/iter 1.00
Pointer_Object_Traverse 49.52667999998539 ns/iter 49.60371999998188 ns/iter 1.00
Pointer_Object_Try_Traverse 65.41366071429269 ns/iter 65.23037500000686 ns/iter 1.00
Pointer_Push_Back_Pointer_To_Weak_Pointer 172.11602938276425 ns/iter 181.32507868975938 ns/iter 0.95
Schema_Frame_OMC_Full 467771350.0000209 ns/iter 471828099.99992514 ns/iter 0.99
Schema_Bundle_Meta_2020_12 23530150.000033244 ns/iter 23264593.333336353 ns/iter 1.01

This comment was automatically generated by workflow using github-action-benchmark.

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (linux/gcc)

Benchmark suite Current: b5cdffb Previous: a620175 Ratio
Schema_Frame_OMC_Full 240810116.99998572 ns/iter 237389582.66665122 ns/iter 1.01
Schema_Bundle_Meta_2020_12 10653629.984610163 ns/iter 10731892.26152723 ns/iter 0.99
Pointer_Object_Traverse 50.10181337816171 ns/iter 51.08949869286732 ns/iter 0.98
Pointer_Object_Try_Traverse 26.48701212236391 ns/iter 26.42297000469834 ns/iter 1.00
Pointer_Push_Back_Pointer_To_Weak_Pointer 160.3842267949935 ns/iter 161.0771321636414 ns/iter 1.00
JSON_Array_Of_Objects_Unique 368.7576082835198 ns/iter 370.85084337601626 ns/iter 0.99
JSON_Parse_1 33664.598658038114 ns/iter 33199.9373779717 ns/iter 1.01
JSON_Fast_Hash_Helm_Chart_Lock 63.10566210321151 ns/iter 68.12999339547459 ns/iter 0.93
JSON_Equality_Helm_Chart_Lock 147.62962380371624 ns/iter 148.94008302153728 ns/iter 0.99
JSON_String_Equal/10 5.7180804649717665 ns/iter 6.645301237076234 ns/iter 0.86
JSON_String_Equal/100 6.341592454392342 ns/iter 7.280372108604318 ns/iter 0.87
JSON_String_Equal_Small_By_Perfect_Hash/10 0.936118025855481 ns/iter 0.934167510367242 ns/iter 1.00
JSON_String_Equal_Small_By_Runtime_Perfect_Hash/10 11.796535363305372 ns/iter 11.796420944646533 ns/iter 1.00
JSON_String_Fast_Hash/10 0.9349994851976029 ns/iter 0.9381684639925444 ns/iter 1.00
JSON_String_Fast_Hash/100 0.9349096664057152 ns/iter 0.934365706380174 ns/iter 1.00
JSON_String_Key_Hash/10 1.2459202575492172 ns/iter 1.245011040508205 ns/iter 1.00
JSON_String_Key_Hash/100 0.9350979995925786 ns/iter 0.9339410523944387 ns/iter 1.00
JSON_Object_Defines_Miss_Same_Length 2.5039604706308958 ns/iter 2.4872637398715502 ns/iter 1.01
JSON_Object_Defines_Miss_Too_Small 2.7979364309627925 ns/iter 2.81339035437787 ns/iter 0.99
JSON_Object_Defines_Miss_Too_Large 2.4919375334949616 ns/iter 2.486964496057659 ns/iter 1.00
Regex_Lower_S_Or_Upper_S_Asterisk 3.1097577152027553 ns/iter 3.106998926118228 ns/iter 1.00
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar 2.8049638218244226 ns/iter 2.7986329887461445 ns/iter 1.00
Regex_Period_Asterisk 2.8044289572892 ns/iter 2.801616048836861 ns/iter 1.00
Regex_Group_Period_Asterisk_Group 2.7995481916335945 ns/iter 2.797887545992384 ns/iter 1.00
Regex_Period_Plus 2.8053615591773706 ns/iter 2.80262585569615 ns/iter 1.00
Regex_Period 2.7987294357855714 ns/iter 2.801684063109589 ns/iter 1.00
Regex_Caret_Period_Plus_Dollar 2.7992268966977267 ns/iter 2.800573068421696 ns/iter 1.00
Regex_Caret_Group_Period_Plus_Group_Dollar 2.804095929160143 ns/iter 2.8014697097425056 ns/iter 1.00
Regex_Caret_Period_Asterisk_Dollar 2.803574431115508 ns/iter 2.7965406922696574 ns/iter 1.00
Regex_Caret_Group_Period_Asterisk_Group_Dollar 2.7979432369983868 ns/iter 2.8014836959529554 ns/iter 1.00
Regex_Caret_X_Hyphen 13.106464171448842 ns/iter 13.120712768983475 ns/iter 1.00
Regex_Period_Md_Dollar 92.6849144553758 ns/iter 88.29098014974127 ns/iter 1.05
Regex_Caret_Slash_Period_Asterisk 7.784457339785916 ns/iter 7.771256803575546 ns/iter 1.00
Regex_Caret_Period_Range_Dollar 3.4195804532759606 ns/iter 3.4203312829595043 ns/iter 1.00
Regex_Nested_Backtrack 829.4732182879665 ns/iter 820.3332359324717 ns/iter 1.01

This comment was automatically generated by workflow using github-action-benchmark.

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (macos/gcc)

Benchmark suite Current: b5cdffb Previous: a620175 Ratio
Regex_Lower_S_Or_Upper_S_Asterisk 1.9623587462481782 ns/iter 2.1606240780953643 ns/iter 0.91
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar 1.9389800422400334 ns/iter 2.2246031470217793 ns/iter 0.87
Regex_Period_Asterisk 1.9430573569690823 ns/iter 2.109533411842049 ns/iter 0.92
Regex_Group_Period_Asterisk_Group 1.9315860470131037 ns/iter 2.193462707373863 ns/iter 0.88
Regex_Period_Plus 1.6469516550742778 ns/iter 2.068652639978767 ns/iter 0.80
Regex_Period 1.6048549335370854 ns/iter 2.2696832071139 ns/iter 0.71
Regex_Caret_Period_Plus_Dollar 1.609542701422055 ns/iter 2.074226578809811 ns/iter 0.78
Regex_Caret_Group_Period_Plus_Group_Dollar 1.6073993145748244 ns/iter 2.0259793694131467 ns/iter 0.79
Regex_Caret_Period_Asterisk_Dollar 1.9194988434251163 ns/iter 2.2997445181085063 ns/iter 0.83
Regex_Caret_Group_Period_Asterisk_Group_Dollar 2.1522351345438167 ns/iter 2.183663213932446 ns/iter 0.99
Regex_Caret_X_Hyphen 6.298595813902177 ns/iter 7.047480525514654 ns/iter 0.89
Regex_Period_Md_Dollar 71.60120222788728 ns/iter 75.2357572123328 ns/iter 0.95
Regex_Caret_Slash_Period_Asterisk 4.5435037996503285 ns/iter 5.28168899973993 ns/iter 0.86
Regex_Caret_Period_Range_Dollar 1.937888686642154 ns/iter 2.2957153182845005 ns/iter 0.84
Regex_Nested_Backtrack 871.3501839445506 ns/iter 968.412919477983 ns/iter 0.90
JSON_Array_Of_Objects_Unique 220.37023887432863 ns/iter 239.77163454337042 ns/iter 0.92
JSON_Parse_1 23285.991348683572 ns/iter 31999.025393176722 ns/iter 0.73
JSON_Fast_Hash_Helm_Chart_Lock 23.554110409972214 ns/iter 28.00148346942007 ns/iter 0.84
JSON_Equality_Helm_Chart_Lock 118.74767725557751 ns/iter 131.7610815599341 ns/iter 0.90
JSON_String_Equal/10 5.539579021320741 ns/iter 5.915491470635798 ns/iter 0.94
JSON_String_Equal/100 5.161372626561699 ns/iter 5.632631065170698 ns/iter 0.92
JSON_String_Equal_Small_By_Perfect_Hash/10 0.7688125651763483 ns/iter 0.9107474160127321 ns/iter 0.84
JSON_String_Equal_Small_By_Runtime_Perfect_Hash/10 3.512942353391748 ns/iter 3.7887943377029636 ns/iter 0.93
JSON_String_Fast_Hash/10 1.9352444280434358 ns/iter 2.0502129653719945 ns/iter 0.94
JSON_String_Fast_Hash/100 1.9168920420170066 ns/iter 2.05648522190618 ns/iter 0.93
JSON_String_Key_Hash/10 1.4485998285392312 ns/iter 1.54195228266046 ns/iter 0.94
JSON_String_Key_Hash/100 1.9569132927677755 ns/iter 2.0626923262842296 ns/iter 0.95
JSON_Object_Defines_Miss_Same_Length 1.7886911163765666 ns/iter 1.9666099217513808 ns/iter 0.91
JSON_Object_Defines_Miss_Too_Small 1.902881334413093 ns/iter 2.038296814647192 ns/iter 0.93
JSON_Object_Defines_Miss_Too_Large 1.7500228488881844 ns/iter 1.8984715369341125 ns/iter 0.92
Pointer_Object_Traverse 55.48826080445096 ns/iter 62.53660060003489 ns/iter 0.89
Pointer_Object_Try_Traverse 36.13547214158979 ns/iter 43.11961279654031 ns/iter 0.84
Pointer_Push_Back_Pointer_To_Weak_Pointer 158.3370523203024 ns/iter 185.08266867276168 ns/iter 0.86
Schema_Frame_OMC_Full 186933517.4560547 ns/iter 251772642.13562012 ns/iter 0.74
Schema_Bundle_Meta_2020_12 8879676.277254835 ns/iter 10956601.82013028 ns/iter 0.81

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.