indexserver: add debug subcommand #288
Merged
+318
−158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a subcommand "debug" to indexserver. The new subcommand contains all debug commands that were previously handled as flags. This means that this commit changes the API but only for debug command. There is no change in how we start indexserver. The debug commands now live in a separate file "debug.go" and don't polute the defintion of the server anymore. I used the vistor pattern as described here peterbourgon/ff#76 to reuse the root flags for some of the debug commands. Other changes: - removed deprecated flag exp-git-index - removed second argument of setupTmpDir because it was not used - sorted imports in main.go How to review: The diff is actually more readable than it appears at first glance. I recommend to start at the bottom of main.go. Most of the changes in main.go come from deleting things relating to debug commands and changing the parameters from pointers to values. Test Plan: - I ran a local instance of Sourcegraph with a verion of Zoekt based on this PR. Start up and indexing were successful. - I built a binary for zoekt-sourcegraph-indexserver, copied it to a production instance and tried out all debug commands
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a subcommand "debug" to indexserver.
The new subcommand contains all debug commands that were previously
handled as flags. This means that this PR changes the API of indexserver
but only for the debug commands. There is no change in how we start indexserver.
The debug commands now live in a separate file "debug.go" and don't polute the
defintion of the server anymore. I used the vistor pattern as described
here peterbourgon/ff#76 to reuse the root flags for some of the debug commands.
Other changes:
How to review:
The diff is actually more readable than it appears at first glance. I
recommend to start at the bottom of main.go. Most of the changes in
main.go come from deleting things related to debug commands and
changing the parameters from pointers to values.
Test Plan:
this PR.
production instance and tried out all debug commands.