This repository has been archived by the owner on Sep 30, 2024. It is now read-only.
guardrails: do case sensitive search #53771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to do this since we are currently looking for exact matches. Additionally attribution searches are slow on dotcom. My working theory for why is related to how we lookup ngrams. By specifying case sensitivity we drastically reduce the number of ngrams we need to check. We also switch the protocol from Batch to Streaming. In practice this makes no difference since we specify count. Using streaming is more consistent with the other search clients. Test Plan: go test
camdencheek
approved these changes
Jun 20, 2023
ErikaRS
pushed a commit
that referenced
this pull request
Jun 22, 2023
We want to do this since we are currently looking for exact matches. Additionally attribution searches are slow on dotcom. My working theory for why is related to how we lookup ngrams. By specifying case sensitivity we drastically reduce the number of ngrams we need to check. We also switch the protocol from Batch to Streaming. In practice this makes no difference since we specify count. Using streaming is more consistent with the other search clients. Test Plan: go test
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to do this since we are currently looking for exact matches. Additionally attribution searches are slow on dotcom. My working theory for why is related to how we lookup ngrams. By specifying case sensitivity we drastically reduce the number of ngrams we need to check.
We also switch the protocol from Batch to Streaming. In practice this makes no difference since we specify count. Using streaming is more consistent with the other search clients.
Test Plan: go test
Part of https://github.com/sourcegraph/sourcegraph/issues/54950