fix: prevent typewriter for answers we already saw #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It you CodyToggle three times (on, off and on again), prompts sent by the user are not rendered as typewrited, but the answers from Cody will be, making the UI very annoying to deal with. This is a crude fix I did in between things during my evening, should be an okay bandage until we see if there's a better place to do this. Basically, if a messeag has been rendered, it assumes it's been completed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It you CodyToggle three times (on, off and on again), prompts sent by the user are not rendered as typewrited, but the answers from Cody will be, making the UI very annoying to deal with.
This is a crude fix I did in between things during my evening, should be an okay bandage until we see if there's a better place to do this.
Basically, if a message has been rendered, it assumes it's been completed. So first time will have the effect, but not afterward.
Before:
CleanShot.2024-03-04.at.12.09.41.mp4
After:
It's instant for old interactions, as expected. Typewriter effect is still there for new answers.