Add definitions and references for constructors #250

SuperAuguste · 2023-04-24T19:29:49Z

Closes #249

This replicates VSCode's gotodef.

Test plan

Tested locally with a snapshot, still need to test edge cases + implement and test inherited constructors.

olafurpg

Impressive first PR @SuperAuguste! This is definitely a tricky issue to fix and I see you've already become familiar with the tsc APIs 😄

It's mostly just me who has worked in this codebase so far and there are many undocumented conventions and assumptions. Don't hesitate to push back if some of these comments are too nitpicky, I prefer to have more relaxed conventions if it makes it easier for more people to contribute (rather than strictly enforcing some undocumented style making it a drudge to contribute).

src/FileIndexer.ts

src/main.test.ts

src/FileIndexer.ts

snapshots/input/syntax/src/constructor.ts

src/FileIndexer.ts

SuperAuguste · 2023-04-25T14:52:25Z

CI failing due to different TypeScript versions :/

I'm kind of lost here, not sure why they're different to be frank.

olafurpg

This PR is really shaping up! Only blocking comments are

Add back your constructor detection logic, but with a cache
Undo changes in yarn.lock, I suspect this might fix the failing CI

snapshots/package.json

src/FileIndexer.ts

SuperAuguste · 2023-04-25T18:05:06Z

Undo changes in yarn.lock, I suspect this might fix the failing CI

The current package.json seems to be invalid due to a peer resolution issue (I ran yarn install --immutable --immutable-cache to not modify the yarn.lock) so my install won't go through. How do you install the deps for this repo without modifying the package.json/lockfile? :)

SuperAuguste · 2023-04-25T18:58:03Z

Figured out the issue - the yarn version used here is a few years behind it seems, so I installed v1.22.19 and everything worked out!

olafurpg

Glorious 😍 Thank you @SuperAuguste!

olafurpg · 2023-04-26T10:24:58Z

Development.md

@@ -1,5 +1,7 @@
 # Developing scip-typescript

+Please note that the yarn version used by CI is `v1.22.19` - you should use this version as well to prevent lockfile conflicts.


Followup #251

olafurpg · 2023-04-26T10:25:30Z

snapshots/output/syntax/src/constructor.ts

+  export function useNoConstructor() {
+//                ^^^^^^^^^^^^^^^^ definition syntax 1.0.0 src/`constructor.ts`/useNoConstructor().
+//                documentation ```ts\nfunction useNoConstructor(): NoConstructor\n```
+    return new NoConstructor()


olafurpg · 2023-04-26T10:27:40Z

src/FileIndexer.ts

      const declaration = sym.declarations?.[0]
      if (!declaration) {
        return undefined
      }
-      const signatureDeclaration: ts.SignatureDeclaration | undefined =


I hadn't realized this was already inside a function 🤦🏻 The new code looks good though 👍🏻

olafurpg · 2023-04-26T10:29:42Z

. How do you install the deps for this repo without modifying the package.json/lockfile? :)

I normally run yarn without a subcommand

olafurpg and others added 2 commits April 24, 2023 18:48

WIP - hacking on adding constructor symbols

b64af4a

Handle constructors properly

fbc2707

SuperAuguste requested review from olafurpg and tjdevries April 24, 2023 19:29

SuperAuguste marked this pull request as draft April 24, 2023 21:34

olafurpg requested changes Apr 25, 2023

View reviewed changes

SuperAuguste force-pushed the olafurpg/constructors branch from 6003a45 to f9212ac Compare April 25, 2023 14:31

Address reviews, consolidate code

c60d510

SuperAuguste force-pushed the olafurpg/constructors branch from f9212ac to c60d510 Compare April 25, 2023 14:36

SuperAuguste requested a review from olafurpg April 25, 2023 14:37

Format code

caa792d

SuperAuguste force-pushed the olafurpg/constructors branch from 808dfd5 to caa792d Compare April 25, 2023 14:45

SuperAuguste marked this pull request as ready for review April 25, 2023 14:48

olafurpg requested changes Apr 25, 2023

View reviewed changes

snapshots/package.json Outdated Show resolved Hide resolved

src/FileIndexer.ts Outdated Show resolved Hide resolved

Fix constructorless classes

b238c58

SuperAuguste force-pushed the olafurpg/constructors branch 2 times, most recently from 3c681b8 to 035d2f6 Compare April 25, 2023 18:57

SuperAuguste force-pushed the olafurpg/constructors branch 2 times, most recently from 595c90b to e5c0992 Compare April 25, 2023 19:02

SuperAuguste requested a review from olafurpg April 25, 2023 19:03

Fix yarn issues, mention yarn version

c597163

SuperAuguste force-pushed the olafurpg/constructors branch from e5c0992 to c597163 Compare April 25, 2023 19:06

olafurpg mentioned this pull request Apr 26, 2023

Upgrade to the latest Yarn #251

Open

olafurpg approved these changes Apr 26, 2023

View reviewed changes

olafurpg merged commit 82c3710 into main Apr 26, 2023

olafurpg deleted the olafurpg/constructors branch April 26, 2023 10:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add definitions and references for constructors #250

Add definitions and references for constructors #250

SuperAuguste commented Apr 24, 2023 •

edited

Loading

olafurpg left a comment

SuperAuguste commented Apr 25, 2023 •

edited

Loading

olafurpg left a comment

SuperAuguste commented Apr 25, 2023

SuperAuguste commented Apr 25, 2023

olafurpg left a comment

olafurpg Apr 26, 2023

olafurpg Apr 26, 2023

olafurpg Apr 26, 2023

olafurpg commented Apr 26, 2023

		@@ -1,5 +1,7 @@
		# Developing scip-typescript

		Please note that the yarn version used by CI is `v1.22.19` - you should use this version as well to prevent lockfile conflicts.

Add definitions and references for constructors #250

Add definitions and references for constructors #250

Conversation

SuperAuguste commented Apr 24, 2023 • edited Loading

Test plan

olafurpg left a comment

Choose a reason for hiding this comment

SuperAuguste commented Apr 25, 2023 • edited Loading

olafurpg left a comment

Choose a reason for hiding this comment

SuperAuguste commented Apr 25, 2023

SuperAuguste commented Apr 25, 2023

olafurpg left a comment

Choose a reason for hiding this comment

olafurpg Apr 26, 2023

Choose a reason for hiding this comment

olafurpg Apr 26, 2023

Choose a reason for hiding this comment

olafurpg Apr 26, 2023

Choose a reason for hiding this comment

olafurpg commented Apr 26, 2023

SuperAuguste commented Apr 24, 2023 •

edited

Loading

SuperAuguste commented Apr 25, 2023 •

edited

Loading