Fixed bug in for loops #1734
Open
Fixed bug in for loops #1734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RichDom2185
reviewed
Feb 11, 2025
| @@ -584,14 +584,14 @@ const cmdEvaluators: { [type: string]: CmdEvaluator } = { | |||
| // Refer to Source §3 specifications https://docs.sourceacademy.org/source_3.pdf | |||
| if (init.type === 'VariableDeclaration' && init.kind === 'let') { | |||
| const id = init.declarations[0].id as es.Identifier | |||
| const valueExpression = init.declarations[0].init! | |||
| // const valueExpression = init.declarations[0].init! | |||
There was a problem hiding this comment.
Let's try to not leave commented code around. If it's unused, remove it entirely, and if it's only unused for now, leave another comment explaining why.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
changes initialisation in for loops to fit Source specification as per #1727
Type of change
How to test
let y=0;
for (let i=(y=y+1);i<=1;i=i+1){
display(i);
}
now runs through a loop and display 1 instead of undefined
Checklist