feat: replace all total xp computations with new backend api #2228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 3144282862Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
shenyih0ng
approved these changes
Sep 29, 2022
| @@ -79,6 +81,8 @@ export const fetchAssessment = (id: number) => action(FETCH_ASSESSMENT, id); | |||
|
|
|||
| export const fetchAssessmentOverviews = () => action(FETCH_ASSESSMENT_OVERVIEWS); | |||
|
|
|||
| export const getTotalXp = () => action(GET_TOTAL_XP); | |||
There was a problem hiding this comment.
just a nit, maybe fetchTotalXp would be a little better? This is so that it is consistent with fetchGrading and fetchAssessmentOverviews.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements the new api route introduced to backend in this PR: source-academy/backend#859
The user profile slide over and XP bar in achievement dashboard will now both get the total XP of the user from the new backend GET
/user/total_xproute.Also includes minor cosmetic changes to the user profile slide over, and achievement milestone components.