Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump guardian #442

Merged
merged 5 commits into from
Jul 22, 2019
Merged

Bump guardian #442

merged 5 commits into from
Jul 22, 2019

Conversation

jiachen247
Copy link
Contributor

@jiachen247 jiachen247 commented Jul 19, 2019 •
edited
Loading

https://brainlid.org/elixir/2016/09/28/mix-task-using-ecto.html

changed depreciated calls to ensure_started and remove dead code and test

In place of #404

@jiachen247 jiachen247 requested a review from geshuming July 19, 2019 06:57
@geshuming
Copy link
Contributor

Do you want to check out this related issue as well? #150

@coveralls
Copy link

coveralls commented Jul 19, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 2576

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.2%) to 95.588%
Files with Coverage Reduction New Missed Lines %
lib/cadet/accounts/query.ex 2 75.0%
Totals Coverage Status
Change from base Build 2571: -0.2%
Covered Lines: 845
Relevant Lines: 884
💛 - Coveralls

@jiachen247
Copy link
Contributor Author

@dependabot rebase

geshuming
geshuming approved these changes Jul 22, 2019
View reviewed changes
Copy link
Contributor

@geshuming geshuming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just remember to resolve #150

@geshuming geshuming merged commit f7f9143 into master Jul 22, 2019
@geshuming geshuming deleted the bump_guardian branch July 26, 2019 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geshuming geshuming geshuming approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jiachen247 @geshuming @coveralls