Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address TODO: when Guardian > v1.1.0 is released #150

Open
indocomsoft opened this issue Jul 21, 2018 · 2 comments
Open

Address TODO: when Guardian > v1.1.0 is released #150

indocomsoft opened this issue Jul 21, 2018 · 2 comments
Assignees
@angelsl
Labels
Question Further information is requested

Comments

@indocomsoft
Copy link
Member

indocomsoft commented Jul 21, 2018 •
edited
Loading

Refactor to use on_refresh callback in the authentication code as well
@martin-henz martin-henz added the Question Further information is requested label Feb 14, 2019
@indocomsoft
Copy link
Member Author

Blocked by #338, because Guardian 2.0 depends on Ecto 3

@geshuming geshuming mentioned this issue Jul 19, 2019
Merged
@indocomsoft
Copy link
Member Author

indocomsoft commented Jul 19, 2019 •
edited
Loading

For reference: https://github.com/source-academy/cadet/blob/master/lib/cadet/auth/guardian.ex#L36 and https://github.com/source-academy/cadet/blob/master/lib/cadet_web/controllers/auth_controller.ex#L62

@angelsl angelsl assigned angelsl and unassigned indocomsoft Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@angelsl angelsl

Labels
Question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@angelsl @indocomsoft @martin-henz