Add unit tests and read scenes from JSON file #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
soumyasen1809
commented
Aug 18, 2024
soumyasen1809
commented
- Add Unit tests for Vector3 and Color
- Updated support to read spheres from JSON file (with Center Point, Radius, Material and other properties)
- Addressed Cippy warnings
- Created initial structure for Unit Testing. - Dependency on Mockall - Vector3 and Color testing started %UNIT_TEST
- Added Unit Tests for Vector3 and Color %UNIT_TEST
%SOFTWARE
- Added JSON file to read sphere properties and add them to the scene. - Parse JSON file with serde_json crate - Balls can have any material with right color, center and radius TODO: Reads only the first element of JSON %SOFTWARE
- Complete JSON file is now parsed to read all spheres %SOFTWARE Fixes issue #16
- Input color value was outside the range 0-1. - Now user can input color(r,g,b) from range (0,255) in the JSON and the code will convert it to appropriate range using the translate_color_to_scale fn %SOFTWARE Fixes issue #17
- Fixed clippy warnings and lint errors %SOFTWARE
- Refactored main.rs to remove ball generation code to another file in lib - Refactored Cargo.toml as required %SOFTWARE
- Minor refactoring and cleanup of codebase %SOFTWARE
soumyasen1809
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.