Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace oodle-sys with Oodle loaded at runtime #38

Merged
merged 4 commits into from
Apr 7, 2024
Merged

Replace oodle-sys with Oodle loaded at runtime #38

merged 4 commits into from
Apr 7, 2024

Conversation

garyttierney
Copy link
Collaborator

@garyttierney garyttierney commented Apr 7, 2024 •
edited
Loading

Resolves #25

@garyttierney garyttierney marked this pull request as ready for review April 7, 2024 05:50
@garyttierney garyttierney requested a review from vswarte as a code owner April 7, 2024 05:50
@github-actions github-actions bot enabled auto-merge April 7, 2024 05:54
vswarte
vswarte approved these changes Apr 7, 2024
View reviewed changes
Copy link
Member

@vswarte vswarte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thus far

@github-actions github-actions bot merged commit 0ca303c into main Apr 7, 2024
4 of 6 checks passed
@github-actions github-actions bot deleted the feat/oodle-rt branch April 7, 2024 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vswarte vswarte vswarte approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Load Oodle at runtime instead of linking to it
2 participants
@garyttierney @vswarte