Entryfilelist parser #31
Conversation
crates/formats/src/entryfilelist.rs
Outdated
| } | ||
|
|
||
| #[allow(unused)] | ||
| pub struct EntryfilelistContainer<'a> { |
There was a problem hiding this comment.
| pub struct EntryfilelistContainer<'a> { | |
| pub struct EntryFileListContainer<'a> { |
crates/formats/src/entryfilelist.rs
Outdated
| self.header.decompressed_size.get() as usize | ||
| } | ||
|
|
||
| pub fn decompress(&self) -> Result<Entryfilelist, EntryfilelistError> { |
There was a problem hiding this comment.
Grabbing all the strings alone is pushing the 500mb rn and its still not done
Is that in reference to this?
There was a problem hiding this comment.
Nope that's the size of the text file generated by entryfilelist-test when piped to a file
crates/formats/src/io_ext/seek.rs
Outdated
| fn seek_until_alignment(&mut self, alignment: usize) -> io::Result<usize>; | ||
| } | ||
|
|
||
| impl<T: Seek> SeekExt for T { |
There was a problem hiding this comment.
I'd make this work over Read and std::io::copy(&mut read.take(required), &mut std::io::sink()) so we can use this on readers that don't support seeking.
There was a problem hiding this comment.
65a45f6 removes it and replaces it with a call to read padding which I think is a bit better
| use fstools_formats::entryfilelist::EntryfilelistContainer; | ||
|
|
||
| #[derive(Parser, Debug)] | ||
| #[command(version, about, long_about = None)] |
There was a problem hiding this comment.
Could you move this to a describe command in the new CLI crate?
vswarte
force-pushed
the
feat/entryfilelist-parser
branch
from
6cc38b7 to
3c9d315
Compare
crates/formats/src/entryfilelist.rs
Outdated
| Self: Sized; | ||
| } | ||
|
|
||
| impl<'a, TElement> Iterator for SectionIter<'a, TElement> |
There was a problem hiding this comment.
T is fine here, I think most people would figure out the T is the element produced by the iterator.
crates/formats/src/entryfilelist.rs
Outdated
|
|
||
| fn next(&mut self) -> Option<Self::Item> { | ||
| if self.entries_read < self.entry_count { | ||
| let result = (self.entries_read..self.entry_count) |
There was a problem hiding this comment.
let result = (self.entries_read < self.entry_count).then(|| {
self.entries_read += 1;
T::read(&mut self.decoder)
});
vswarte
force-pushed
the
feat/entryfilelist-parser
branch
from
b26b412 to
41b6fd1
Compare
No description provided.