Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Asset Server crate #21

Merged
merged 17 commits into from
Mar 17, 2024
Merged

Create Asset Server crate #21

merged 17 commits into from
Mar 17, 2024

Conversation

garyttierney
Copy link
Collaborator

@garyttierney garyttierney commented Mar 3, 2024

Future improvements:

  • Allow unmounting
  • Better mmap allocation usage (don't create lots of small mmaps)
  • Usage tracking so we don't emit Modification events for assets that haven't been requested yet

@garyttierney garyttierney requested a review from vswarte as a code owner March 3, 2024 17:42
@garyttierney garyttierney marked this pull request as draft March 3, 2024 20:58
@vswarte vswarte self-requested a review March 3, 2024 21:57
@vswarte
Copy link
Member

vswarte commented Mar 3, 2024

Realized it was still in draft after approving

@garyttierney garyttierney marked this pull request as ready for review March 15, 2024 23:16
@garyttierney garyttierney merged commit 689ee73 into main Mar 17, 2024
4 checks passed
@garyttierney garyttierney deleted the feat/asset-server branch March 17, 2024 01:40
Copy link
Member

@vswarte vswarte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested ack

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants