Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make padding mismatches an error under the strict_padding feature #14

Merged
merged 2 commits into from
Feb 29, 2024
Merged

Make padding mismatches an error under the strict_padding feature #14

merged 2 commits into from
Feb 29, 2024

Conversation

garyttierney
Copy link
Collaborator

No description provided.

@garyttierney garyttierney requested a review from vswarte February 28, 2024 21:02
vswarte
vswarte approved these changes Feb 29, 2024
View reviewed changes
Copy link
Member

@vswarte vswarte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, hadn't considered putting it its own feature flag

@garyttierney garyttierney merged commit faf1139 into main Feb 29, 2024
1 check passed
@garyttierney garyttierney deleted the feat/padding-checks-error branch February 29, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vswarte vswarte vswarte approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@garyttierney @vswarte