Instanced Projects, AssetLocator, ParamBank, FMGBank #895
Conversation
…p settings in project because looseparams option. Also also it's still used all over and is good for serialization.
…tate in the fmgbank
Philiquaz
changed the title
| public static GameType GetGameTypeForExePath(string exePath) | ||
| { | ||
| var type = GameType.Undefined; | ||
| if (exePath.ToLower().Contains("darksouls.exe")) |
There was a problem hiding this comment.
maybe a static dictionary for a fast lookup? (for all the switches here, might add up if summed)
There was a problem hiding this comment.
It might, but then there's the nuanced cases like des vs bb, or in other such methods the shared cases.
For the whole file, I think ideally we'd define an object/jumptable and do some scummy OOP to handle per-game behaviours (and reuse this "game implementation" class for different databanks eg param loading code, fmg loading code etc.)
But moving to that sort of system might be a step beyond what this PR is focusing on, which is more to instantiate projects and databanks separately, as well as just clean up some asset lookup code.
That is, if I'm understanding your point.
In terms of performance, this particular function is negligibly used.
Instanced FMGBank, more utilities and statics gutted.
FMGBank completely restructured.
Includes merges of assetbrowser but does not yet instance it or move it to new assetlocator utilities