Add beefy light client tests and benchamarks #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
N1ghtStorm
changed the title
wer1st
reviewed
Mar 10, 2023
| } | ||
|
|
||
|
|
||
| submit_signature_commitment_10_128 { |
There was a problem hiding this comment.
What is output of your benchmarks?
As I see the result is not mapped to WeightInfo trait.
Also how did you get submit_signature_commitment() weight? Because you will get of methods submit_signature_commitment_x_y() with different weights?
Comment on lines
+82
to
+84
| fn initialize() -> Weight; | ||
|
|
||
| fn submit_signature_commitment() -> Weight; |
There was a problem hiding this comment.
Suggested change
| fn initialize() -> Weight; | |
| fn submit_signature_commitment() -> Weight; | |
| fn initialize() -> Weight; | |
| fn submit_signature_commitment() -> Weight; |
| @@ -217,7 +233,7 @@ pub mod pallet { | |||
| Ok(().into()) | |||
| } | |||
|
|
|||
| #[pallet::weight(0)] | |||
| #[pallet::weight(<T as Config>::WeightInfo::submit_signature_commitment())] | |||
There was a problem hiding this comment.
Looking at your benchmarks I think you need to rework the weight of submit_signature_commitment()
wer1st
reviewed
Mar 10, 2023
|
|
||
| submit_signature_commitment_20_256 { | ||
| let validators = 20; | ||
| let tree_size = 256; |
wer1st
reviewed
Mar 10, 2023
| mod benchmark_features; | ||
|
|
||
| #[cfg(any(test, feature = "runtime-benchmarks"))] | ||
| // #[cfg(test)] |
There was a problem hiding this comment.
Do you need this commented code?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.