-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 멤버 프로필 등록/수정 mds 적용 #1717
Open
simeunseo
wants to merge
23
commits into
main
Choose a base branch
from
feat/#1716
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 프리뷰 배포 확인하기 🚀 |
simeunseo
force-pushed
the
feat/#1716
branch
2 times, most recently
from
January 4, 2025 22:42
0ebf32e
to
d9a78c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤫 쉿, 나한테만 말해줘요. 이슈넘버
🧐 어떤 것을 변경했어요~?
멤버 수정 폼 mds 적용
🤔 그렇다면, 어떻게 구현했어요~?
❤️🔥 당신이 생각하는 PR포인트, 내겐 매력포인트.
files changed가 많은데, 자잘한 css 수정과 mds Select 적용을 위한 상수 수정 등이 대부분입니다. 이런 부분은 가볍게 봐주시고,
pc/mobile 반응형 UI에 문제가 없는지, 폼 수정 동작이 문제 없이 잘 동작하는지를 위주로 확인해주시면 좋을 것 같습니다!!
코드상에서 가장 영향이 있는 부분은 mds TextField/TextArea/Select 교체 부분일듯합니다. 이 또한 반복적인 코드여서 모두 확인하실 필요는 없어보입니다.
pc/모바일에서 각각 select/bottomsheet로 달라져야하는 부분과, pc에서는 textField인데 mobile에서는 textArea인 경우가 많아서 이는 전부
<Responsive>
로 처리했습니다.이 외 레이아웃 반응형에 대해서는 최대한 media query로 해결했습니다.
📸 스크린샷, 없으면 이것 참,, 섭섭한데요?