Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 커뮤니티 리스트에 사용되는 FeedCard 구현 #1037

Merged
merged 16 commits into from
Nov 12, 2023
Merged

Conversation

juno7803
Copy link
Collaborator

@juno7803 juno7803 commented Oct 28, 2023

🤫 쉿, 나한테만 말해줘요. 이슈넘버

🧐 어떤 것을 변경했어요~?

  • main에 사용되는 친구는 src/feed/FeedCard 이고, 상세에 사용되는 친구는 src/feed/DetailFeedCard 입니당
  • 살짝 쪼개서 작업해보았는데용, 어차피 다른곳에 재사용은 어렵지만, 최대한 유지보수할때 분리해서 볼 수 있도록 쪼갰다고만 생각해주세요 ㅎㅎ.. 어렵네요.. 스토리북에 예시가 있으니 어떻게 조합하는지는 스토리북을 봐주시면 될 것 같아용
  • storybook에 emotion css prop을 사용할 수 있도록 바벨설정을 추가했어요

🤔 그렇다면, 어떻게 구현했어요~?

❤️‍🔥 당신이 생각하는 PR포인트, 내겐 매력포인트.

📸 스크린샷, 없으면 이것 참,, 섭섭한데요?

2023-11-04.8.15.26.mov

@juno7803 juno7803 self-assigned this Oct 28, 2023
@juno7803 juno7803 marked this pull request as draft October 28, 2023 07:47
@github-actions
Copy link

github-actions bot commented Oct 28, 2023

🚀 프리뷰 배포 확인하기 🚀

https://ee8668c2.sopt-internal-dev.pages.dev

@github-actions
Copy link

github-actions bot commented Oct 28, 2023

✨✨ 스토리북으로 확인하기 ✨✨

@juno7803 juno7803 marked this pull request as ready for review November 4, 2023 11:14
@juno7803 juno7803 requested a review from Tekiter November 4, 2023 11:47
@juno7803 juno7803 mentioned this pull request Nov 5, 2023
import dayjs from 'dayjs';
import relativeTime from 'dayjs/plugin/relativeTime';

dayjs.locale('ko');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

질문) 이거 다른 파일에서 여러번 호출되어도 괜찮나요?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Tekiter 네네 문제없습니다! app.tsx에 한번만 적어줘서 어떤 페이지에서든 사용하게 할 수도 있긴 한데, 플러그인들 그리 자주 사용하진 않을 거같아서 사용하는 곳에서 불러오도록 했어용

@juno7803 juno7803 enabled auto-merge November 12, 2023 13:21
@juno7803 juno7803 added this pull request to the merge queue Nov 12, 2023
Merged via the queue into main with commit b1612b7 Nov 12, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: 커뮤니티 피드 카드 컴포넌트 구현
2 participants